Validate if table or dataset not exist and throw exception

Author: romanbracinik

src/Schema/Bigquery/BigquerySchemaReflection.php

@@ -7,6 +7,7 @@
 use Google\Cloud\BigQuery\BigQueryClient;
 use Keboola\TableBackendUtils\Escaping\Bigquery\BigqueryQuote;
 use Keboola\TableBackendUtils\Schema\SchemaReflectionInterface;
+use Keboola\TableBackendUtils\TableNotExistsReflectionException;
 use LogicException;
 
 class BigquerySchemaReflection implements SchemaReflectionInterface
@@ -26,6 +27,10 @@ public function __construct(BigQueryClient $bqClient, string $datasetName)
      */
     public function getTablesNames(): array
     {
+        $isDatasetExist = $this->bqClient->dataset($this->datasetName)->exists();
+        if ($isDatasetExist === false) {
+            throw new ReflectionException(sprintf('Dataset "%s" not found', $this->datasetName));
+        }
         $query = $this->bqClient->query(
             sprintf(
                 'SELECT * FROM %s.INFORMATION_SCHEMA.TABLES;',
@@ -65,6 +70,41 @@ public function getTablesNames(): array
      */
     public function getViewsNames(): array
     {
-        throw new LogicException('Not implemented');
+        $isDatasetExist = $this->bqClient->dataset($this->datasetName)->exists();
+        if ($isDatasetExist === false) {
+            throw new TableNotExistsReflectionException(sprintf('Dataset "%s" not found', $this->datasetName));
+        }
+        $query = $this->bqClient->query(
+            sprintf(
+                'SELECT * FROM %s.INFORMATION_SCHEMA.VIEWS;',
+                BigqueryQuote::quoteSingleIdentifier($this->datasetName),
+            )
+        );
+        $queryResults = $this->bqClient->runQuery($query);
+
+        $tables = [];
+        /**
+         * @var array{
+         *  table_catalog: string,
+         *  table_schema: string,
+         *  table_name: string,
+         *  table_type: string,
+         *  is_insertable_into: string,
+         *  is_typed: string,
+         *  creation_time: string,
+         *  base_table_catalog: string,
+         *  base_table_schema: string,
+         *  base_table_name: string,
+         *  snapshot_time_ms: string,
+         *  ddl: string,
+         *  snapshot_time_ms: string,
+         *  default_collation_name: string,
+         *  upsert_stream_apply_watermark: string,
+         * } $row
+         */
+        foreach ($queryResults as $row) {
+            $tables[] = $row['table_name'];
+        }
+        return $tables;
     }
 }

src/Table/Bigquery/BigqueryTableReflection.php

@@ -35,6 +35,9 @@ public function __construct(BigQueryClient $bqClient, string $datasetName, strin
     /** @return  string[] */
     public function getColumnsNames(): array
     {
+        if ($this->exists() === false) {
+            throw new TableNotExistsReflectionException(sprintf('Table "%s" not found', $this->tableName));
+        }
         $query = $this->bqClient->query(
             sprintf(
                 'SELECT column_name FROM %s.INFORMATION_SCHEMA.COLUMNS WHERE table_name = %s',
@@ -71,6 +74,9 @@ public function getColumnsNames(): array
 
     public function getColumnsDefinitions(): ColumnCollection
     {
+        if ($this->exists() === false) {
+            throw new TableNotExistsReflectionException(sprintf('Table "%s" not found', $this->tableName));
+        }
         $query = $this->bqClient->query(
             sprintf(
                 'SELECT * EXCEPT(is_generated, generation_expression, is_stored, is_updatable) 
@@ -110,6 +116,9 @@ public function getColumnsDefinitions(): ColumnCollection
 
     public function getRowsCount(): int
     {
+        if ($this->exists() === false) {
+            throw new TableNotExistsReflectionException(sprintf('Table "%s" not found', $this->tableName));
+        }
         $query = $this->bqClient->query(sprintf(
             'SELECT COUNT(*) AS NumberOfRows FROM %s.%s',
             BigqueryQuote::quoteSingleIdentifier($this->datasetName),
@@ -131,6 +140,9 @@ public function getPrimaryKeysNames(): array
 
     public function getTableStats(): TableStatsInterface
     {
+        if ($this->exists() === false) {
+            throw new TableNotExistsReflectionException(sprintf('Table "%s" not found', $this->tableName));
+        }
         $sql = sprintf(
             'SELECT size_bytes FROM %s.__TABLES__ WHERE table_id=%s',
             BigqueryQuote::quoteSingleIdentifier($this->datasetName),
@@ -177,6 +189,6 @@ public function getTableDefinition(): TableDefinitionInterface
 
     public function exists(): bool
     {
-        throw new LogicException('Not implemented');
+        return $this->bqClient->dataset($this->datasetName)->table($this->tableName)->exists();
     }
 }

tests/Functional/Bigquery/Table/BigqueryTableQueryBuilderTest.php

@@ -11,6 +11,7 @@
 use Keboola\TableBackendUtils\Column\ColumnCollection;
 use Keboola\TableBackendUtils\Table\Bigquery\BigqueryTableQueryBuilder;
 use Keboola\TableBackendUtils\Table\Bigquery\BigqueryTableReflection;
+use Keboola\TableBackendUtils\TableNotExistsReflectionException;
 use Tests\Keboola\TableBackendUtils\Functional\Bigquery\BigqueryBaseCase;
 
 class BigqueryTableQueryBuilderTest extends BigqueryBaseCase
@@ -102,7 +103,7 @@ public function testGetDropTableCommand(): void
         $this->bqClient->runQuery($this->bqClient->query($sql));
 
         // test NON existence of old table via counting
-        $this->expectException(NotFoundException::class);
+        $this->expectException(TableNotExistsReflectionException::class);
         $ref->getRowsCount();
     }
 }