Skip to content

Commit 658fdd3

Browse files
committed
Review PreservationAgentController and PreservationAgentService
1 parent 59a9451 commit 658fdd3

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

roda-ui/roda-wui/src/main/java/org/roda/wui/api/v2/controller/PreservationAgentController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ public ResponseEntity<StreamingResponseBody> downloadPreservationAgent(
105105
public ResponseEntity<StreamingResponseBody> process(RequestContext requestContext,
106106
RequestControllerAssistant controllerAssistant) throws RODAException, RESTException {
107107
controllerAssistant.setRelatedObjectId(id);
108-
StreamResponse response = preservationAgentService.retrievePreservationAgentFile(id);
108+
StreamResponse response = preservationAgentService.retrievePreservationAgentFile(requestContext.getModelService(), id);
109109

110110
return ApiUtils.okResponse(response);
111111
}

roda-ui/roda-wui/src/main/java/org/roda/wui/api/v2/services/PreservationAgentService.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package org.roda.wui.api.v2.services;
22

3-
import org.roda.core.RodaCoreFactory;
43
import org.roda.core.data.common.RodaConstants;
54
import org.roda.core.data.exceptions.AuthorizationDeniedException;
65
import org.roda.core.data.exceptions.GenericException;
@@ -19,11 +18,9 @@
1918
@Service
2019
public class PreservationAgentService {
2120

22-
public StreamResponse retrievePreservationAgentFile(String id)
21+
public StreamResponse retrievePreservationAgentFile(ModelService model, String id)
2322
throws GenericException, RequestNotValidException, NotFoundException, AuthorizationDeniedException {
2423

25-
ModelService model = RodaCoreFactory.getModelService();
26-
2724
final Binary binary = model.retrievePreservationAgent(id);
2825

2926
final ConsumesOutputStream stream = new BinaryConsumesOutputStream(binary,

0 commit comments

Comments
 (0)