Rename filesystem StorageService copy to export and mark as READ operation (#3555)

* changed transactional operation type, CREATE to READ in DefaultTransactionalStorageService's copy method.

* refactored copy method that received toPath argument to export to file system.

* formatted code style.

Author: eduardojst10

roda-core/roda-core/src/main/java/org/roda/core/model/DefaultModelService.java

@@ -5627,13 +5627,13 @@ public void exportObject(LiteRODAObject lite, StorageService toStorage, String..
   public void exportToPath(IsRODAObject object, Path toPath, boolean replaceExisting, String... fromPathPartials)
     throws RequestNotValidException, AuthorizationDeniedException, AlreadyExistsException, GenericException {
     StoragePath sourceObjectPath = DefaultStoragePath.parse(ModelUtils.getStoragePath(object), fromPathPartials);
-    getStorage().copy(getStorage(), sourceObjectPath, toPath, "", replaceExisting);
+    getStorage().export(getStorage(), sourceObjectPath, toPath, "", replaceExisting);
   }
 
   public void exportToPath(LiteRODAObject lite, Path toPath, boolean replaceExisting, String... fromPathPartials)
     throws RequestNotValidException, AuthorizationDeniedException, AlreadyExistsException, GenericException {
     StoragePath sourceObjectPath = DefaultStoragePath.parse(ModelUtils.getStoragePath(lite), fromPathPartials);
-    getStorage().copy(getStorage(), sourceObjectPath, toPath, "", replaceExisting);
+    getStorage().export(getStorage(), sourceObjectPath, toPath, "", replaceExisting);
   }
 
   @Override

roda-core/roda-core/src/main/java/org/roda/core/model/DefaultTransactionalModelService.java

@@ -3933,7 +3933,7 @@ public void exportToPath(IsRODAObject object, Path toPath, boolean replaceExisti
     throws RequestNotValidException, AuthorizationDeniedException, AlreadyExistsException, GenericException {
     TransactionalModelOperationLog operationLog = operationRegistry.registerOperation(object, OperationType.READ);
     try {
-      getModelService().exportToPath(object, toPath, replaceExisting, fromPathPartials);
+      mainModelService.exportToPath(object, toPath, replaceExisting, fromPathPartials);
       operationRegistry.updateOperationState(operationLog, OperationState.SUCCESS);
     } catch (RequestNotValidException | AuthorizationDeniedException | AlreadyExistsException | GenericException e) {
       operationRegistry.updateOperationState(operationLog, OperationState.FAILURE);

roda-core/roda-core/src/main/java/org/roda/core/storage/DefaultTransactionalStorageService.java

@@ -421,12 +421,12 @@ public void copy(StorageService fromService, StoragePath fromStoragePath, Storag
   }
 
   @Override
-  public void copy(StorageService fromService, StoragePath fromStoragePath, Path toPath, String resource,
+  public void export(StorageService fromService, StoragePath fromStoragePath, Path toPath, String resource,
     boolean replaceExisting) throws AlreadyExistsException, GenericException, AuthorizationDeniedException {
     List<TransactionalStoragePathOperationLog> operationLogs = registerOperationForCopy(fromService, fromStoragePath,
-      toPath, OperationType.CREATE);
+      toPath, OperationType.READ);
     try {
-      stagingStorageService.copy(fromService, fromStoragePath, toPath, resource, replaceExisting);
+      stagingStorageService.export(fromService, fromStoragePath, toPath, resource, replaceExisting);
       for (TransactionalStoragePathOperationLog operationLog : operationLogs) {
         updateOperationState(operationLog, OperationState.SUCCESS);
       }
@@ -909,8 +909,8 @@ private List<TransactionalStoragePathOperationLog> registerOperationForCopy(Stor
   private List<TransactionalStoragePathOperationLog> registerOperationForCopy(StorageService fromService,
     StoragePath fromStoragePath, StoragePath toStoragePath, OperationType operation)
     throws AuthorizationDeniedException, GenericException {
-    List<TransactionalStoragePathOperationLog> ret = new ArrayList<>(
-      List.of(registerOperation(toStoragePath, operation)));
+    List<TransactionalStoragePathOperationLog> ret = new ArrayList<>();
+    ret.add(registerOperation(toStoragePath,operation));
     try (CloseableIterable<Resource> listResourcesUnderDirectory = fromService
       .listResourcesUnderDirectory(fromStoragePath, true)) {
       if (listResourcesUnderDirectory == null) {

roda-core/roda-core/src/main/java/org/roda/core/storage/StorageService.java

@@ -347,7 +347,7 @@ void copy(StorageService fromService, StoragePath fromStoragePath, StoragePath t
     throws AlreadyExistsException, GenericException, RequestNotValidException, NotFoundException,
     AuthorizationDeniedException;
 
-  void copy(StorageService fromService, StoragePath fromStoragePath, Path toPath, String resource, boolean replaceExisting)
+  void export(StorageService fromService, StoragePath fromStoragePath, Path toPath, String resource, boolean replaceExisting)
     throws AlreadyExistsException, GenericException, AuthorizationDeniedException;
 
   /**

roda-core/roda-core/src/main/java/org/roda/core/storage/StorageServiceWrapper.java

@@ -179,10 +179,10 @@ public void copy(StorageService fromService, StoragePath fromStoragePath, Storag
   }
 
   @Override
-  public void copy(StorageService fromService, StoragePath fromStoragePath, Path toPath, String resource,
+  public void export(StorageService fromService, StoragePath fromStoragePath, Path toPath, String resource,
     boolean replaceExisting) throws AlreadyExistsException, GenericException, AuthorizationDeniedException {
     RodaCoreFactory.checkIfWriteIsAllowedAndIfFalseThrowException(nodeType);
-    storageService.copy(fromService, fromStoragePath, toPath, resource, false);
+    storageService.export(fromService, fromStoragePath, toPath, resource, replaceExisting);
   }
 
   @Override

roda-core/roda-core/src/main/java/org/roda/core/storage/fs/FileStorageService.java

@@ -567,7 +567,7 @@ public void copy(StorageService fromService, StoragePath fromStoragePath, Storag
   }
 
   @Override
-  public void copy(StorageService fromService, StoragePath fromStoragePath, Path toPath, String resource,
+  public void export(StorageService fromService, StoragePath fromStoragePath, Path toPath, String resource,
     boolean replaceExisting) throws AlreadyExistsException, GenericException {
     Path sourcePath = null;
     if (StringUtils.isNotBlank(resource)) {