Skip to content

Commit 8f4926f

Browse files
committed
Ruby 3.4.3にアップグレードした
単純にRubyのバージョンだけの変更ではうまくいかなかったので差分が比較的多いです。 まずRubyのバージョンを上げてテストを実行したところ、次のようなエラーになりました ``` /Users/willnet/.rbenv/versions/3.4.3/lib/ruby/gems/3.4.0/gems/minitest-5.16.3/lib/minitest.rb:3:in 'Kernel#require': cannot load such file -- mutex_m (LoadError) ``` minitestが依存していた[mutex_m](https://github.com/ruby/mutex_m)がbundled gemになった結果このエラーになったと判断し、bundle updateでminitestのバージョンを上げました。 すると今度は次のようなエラーになりました。 ``` /Users/willnet/ghq/github.com/kinoppyd/reading-metaprogramming-ruby/00_setup/test/test_try_out.rb:4:in '<top (required)>': uninitialized constant MiniTest (NameError) class TestTryOut < MiniTest::Test ``` これは、"MiniTest"という古い参照の仕方が[+ Only load minitest/unit (aka ancient MiniTest compatibility layer) … · minitest/minitest@a2c6c18](https://github.com/minitest/minitest/commit/a2c6c18570f6f0a1bf6af70fe3b6d9599a13fdd6)で消されたのが原因のようです。一括置換で"Minitest"に変更して対応しました。 これでテストが通るようになったので大丈夫なはず。
1 parent f6c158b commit 8f4926f

14 files changed

Lines changed: 23 additions & 25 deletions

File tree

.ruby-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3.3.1
1+
3.4.3

00_setup/test/test_try_out.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
require 'test_helper'
22
require '01_try_out'
33

4-
class TestTryOut < MiniTest::Test
4+
class TestTryOut < Minitest::Test
55
def test_first_last_name
66
target = TryOut.new("John", "Wick")
77
assert_equal "John Wick", target.full_name
@@ -48,4 +48,3 @@ def test_too_many_arguments
4848
assert_raises (ArgumentError) {TryOut.new("John", "Milton", "Cage", "Jr")}
4949
end
5050
end
51-

02_object_model/test/test_hierarchy.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
require 'test_helper'
22
require '02_hierarchy'
33

4-
class TestHierarchy < MiniTest::Test
4+
class TestHierarchy < Minitest::Test
55
def test_c1_ancestors
66
assert_equal [C1, M1], C1.ancestors.first(2)
77
end

02_object_model/test/test_hoge.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
require 'test_helper'
22
require '01_hoge'
33

4-
class TestHoge < MiniTest::Test
4+
class TestHoge < Minitest::Test
55
def test_hoge_in_string
66
assert_equal "hoge","hoge".hoge
77
end

03_method/test/test_define.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
require '02_define'
33
require 'securerandom'
44

5-
class TestDefine < MiniTest::Test
5+
class TestDefine < Minitest::Test
66

77
begin
88
class A3

03_method/test/test_method_first_step.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
require 'securerandom'
33
require '01_method_first_step'
44

5-
class TestMethodFirstStep < MiniTest::Test
5+
class TestMethodFirstStep < Minitest::Test
66
def test_hello
77
assert_equal F1.new.hello, 'hello'
88
end

03_method/test/test_try_over3_3.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
class TestTryOver03Q1 < Minitest::Test
55
def test_q1_called_run_test
66
a1 = TryOver3::A1.new
7-
mock = MiniTest::Mock.new
7+
mock = Minitest::Mock.new
88
a1.stub(:run_test, mock) do
99
a1.test_hoge
1010
end
@@ -121,4 +121,3 @@ def orignal_accessor_included_instance
121121
end.new
122122
end
123123
end
124-

04_block/test/test_block_first_step.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ def self.call(&block)
1212

1313
require '01_block_first_step'
1414

15-
class TestBlockFirstStep < MiniTest::Test
15+
class TestBlockFirstStep < Minitest::Test
1616
def test_my_math
1717
assert_equal 4, MyMath.new.two_times { 2 }
1818
end

04_block/test/test_evil_mailbox.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
require '02_evil_mailbox'
33
require 'securerandom'
44

5-
class TestEvilMailbox < MiniTest::Test
5+
class TestEvilMailbox < Minitest::Test
66
def evil_mailbox(&block)
7-
mock = MiniTest::Mock.new
7+
mock = Minitest::Mock.new
88
mock.instance_eval(&block) if block_given?
99
[EvilMailbox.new(mock), mock]
1010
end
@@ -58,15 +58,15 @@ def test_send_mail_exec_block_with_result_false
5858

5959
def test_mail_object_auth
6060
secret_string = SecureRandom.hex
61-
mock = MiniTest::Mock.new
61+
mock = Minitest::Mock.new
6262
mock.expect :auth, true, [String]
6363
EvilMailbox.new(mock, secret_string)
6464
mock.verify
6565
end
6666

6767
def test_send_mail_with_secret_string
6868
secret_string = SecureRandom.hex
69-
mock = MiniTest::Mock.new
69+
mock = Minitest::Mock.new
7070
mock.expect :auth, true, [String]
7171
mock.expect :send_mail, true, ["ppyd", "hello#{secret_string}"]
7272
mb = EvilMailbox.new(mock, secret_string)
@@ -77,7 +77,7 @@ def test_send_mail_with_secret_string
7777

7878
def test_no_secret_string_in_object
7979
secret_string = SecureRandom.hex
80-
mock = MiniTest::Mock.new
80+
mock = Minitest::Mock.new
8181
mock.expect :auth, true, [String]
8282
mb = EvilMailbox.new(mock, secret_string)
8383

@@ -91,7 +91,7 @@ def test_no_secret_string_in_object
9191
end
9292

9393
def evil_mailbox_with_secret_string(secret_string, &block)
94-
mock = MiniTest::Mock.new
94+
mock = Minitest::Mock.new
9595
mock.instance_eval(&block) if block_given?
9696
[EvilMailbox.new(mock, secret_string), mock]
9797
end

04_block/test/test_simple_bot.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
require 'securerandom'
33
require '03_simple_bot'
44

5-
class TestSimpleBot < MiniTest::Test
5+
class TestSimpleBot < Minitest::Test
66
def bot_for_test(&block)
77
Class.new(SimpleBot, &block)
88
end

0 commit comments

Comments
 (0)