Exception must be thrown outside the retry loop (#401)

ckkashyap · ckkMicrosoft · web-flow · commit c2f9b2a6b24c · 2023-04-17T14:07:26.000-07:00
* Exception must be thrown outside the retry loop * package-lock.json * Revert "package-lock.json" This reverts commit 2b266d6. --------- Co-authored-by: CK Kashyap <ckk@microsoft.com>
diff --git a/src/directLineStreaming.ts b/src/directLineStreaming.ts
@@ -337,11 +337,12 @@ export class DirectLineStreaming implements IBotConnection {
         }
       } catch (err) {
         console.error(`Failed to connect ${err}`);
-        throw(err);
       }
 
       await new Promise(r => setTimeout(r, this.getRetryDelay()));
     }
+
+    throw (new Error(`Failed to connect after ${MAX_RETRY_COUNT} attempts`));
   }
 
   // Returns the delay duration in milliseconds

Original file line number	Diff line number	Diff line change
`@@ -337,11 +337,12 @@ export class DirectLineStreaming implements IBotConnection {`
`337`	`337`	`}`
`338`	`338`	`} catch (err) {`
`339`	`339`	console.error(`Failed to connect ${err}`);
`340`		`- throw(err);`
`341`	`340`	`}`
`342`	`341`
`343`	`342`	`await new Promise(r => setTimeout(r, this.getRetryDelay()));`
`344`	`343`	`}`
	`344`	`+`
	`345`	+ throw (new Error(`Failed to connect after ${MAX_RETRY_COUNT} attempts`));
`345`	`346`	`}`
`346`	`347`
`347`	`348`	`// Returns the delay duration in milliseconds`