Fix: connection should not auto retry after DirectLineStreaming.end() (#393)

* fix connectRetry when DirectLineStreaming.end()

* add test case

* add comment todo

---------

Co-authored-by: fangyangci <fangyangci@microsoft.com>

Author: woasishen

__tests__/happy.dlstreamConnection.js

@@ -0,0 +1,29 @@
+import 'dotenv/config';
+
+import onErrorResumeNext from 'on-error-resume-next';
+
+import { timeouts } from './constants.json';
+import * as createDirectLine from './setup/createDirectLine';
+import waitForConnected from './setup/waitForConnected';
+
+// TODO: Need more realistic testing.
+//       - Able to connect to a Web Socket server
+//       - Make sure after `end` is called, the client will not reconnect
+//       - If the connection is disrupted, make sure the client will reconnect
+//       - Use a fake timer to speed up the test
+describe('test dl streaming end', () => {
+  let unsubscribes;
+  let directLine;
+  const ConnectionStatusEnd = 5;
+  beforeEach(() => unsubscribes = []);
+  afterEach(() => unsubscribes.forEach(fn => onErrorResumeNext(fn)));
+  test('using Streaming Extensions', async () => {
+    jest.setTimeout(30000);
+    directLine = await createDirectLine.forStreamingExtensions();
+    unsubscribes.push(directLine.end.bind(directLine));
+    unsubscribes.push(await waitForConnected(directLine));
+    await new Promise(resolve => setTimeout(resolve, 2000));
+    directLine.end();
+    expect(directLine.connectionStatus$.getValue()).toBe(ConnectionStatusEnd);
+  })
+});

src/directLineStreaming.ts

@@ -316,6 +316,10 @@ export class DirectLineStreaming implements IBotConnection {
       try {
         this.connectionStatus$.next(ConnectionStatus.Connecting);
         const res = await this.connectAsync();
+        if (this.connectionStatus$.getValue() === ConnectionStatus.Ended){
+          console.warn('Connection end');
+          break;
+        }
         console.warn(`Retrying connection ${res}`);
         if (60000 < Date.now() - start) {
           // reset the retry counter and retry immediately