Skip to content

Commit f876daa

Browse files
compulima-b-r-o-w-n
authored andcommitted
do not warn if polling interval is undefined (#161)
* Remove warning if undefined * Add entry
1 parent 1e75e78 commit f876daa

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
1414
-->
1515

1616
## [Unreleased]
17+
### Fixed
18+
- Fix [#160](https://github.com/Microsoft/BotFramework-DirectLineJS/issues/160). Removed warning if `pollingInterval` is `undefined`, by [@compulim](https://github.com/compulim) in PR [#161](https://github.com/Microosft/BotFramework-DirectLineJS/pull/161)
1719

1820
## [0.11.2] - 2019-02-05
1921
### Fixed

src/directLine.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,9 @@ export class DirectLine implements IBotConnection {
438438
const parsedPollingInterval = ~~options.pollingInterval;
439439

440440
if (parsedPollingInterval < POLLING_INTERVAL_LOWER_BOUND) {
441-
console.warn(`DirectLineJS: provided pollingInterval (${ options.pollingInterval }) is under lower bound (200ms), using default of 1000ms`);
441+
if (typeof options.pollingInterval !== 'undefined') {
442+
console.warn(`DirectLineJS: provided pollingInterval (${ options.pollingInterval }) is under lower bound (200ms), using default of 1000ms`);
443+
}
442444
} else {
443445
this.pollingInterval = parsedPollingInterval;
444446
}

0 commit comments

Comments
 (0)