fix: skip inline agent mode for chat view chat mode selector. (#1603)

Author: ethanyhou

com.microsoft.copilot.eclipse.core.test/src/com/microsoft/copilot/eclipse/core/chat/service/BuiltInChatModeServiceTests.java

@@ -0,0 +1,72 @@
+package com.microsoft.copilot.eclipse.core.chat.service;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.when;
+
+import java.lang.reflect.Field;
+import java.util.List;
+import java.util.concurrent.CompletableFuture;
+
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+import com.microsoft.copilot.eclipse.core.CopilotCore;
+import com.microsoft.copilot.eclipse.core.chat.BuiltInChatMode;
+import com.microsoft.copilot.eclipse.core.lsp.CopilotLanguageServerConnection;
+import com.microsoft.copilot.eclipse.core.lsp.protocol.ConversationMode;
+import com.microsoft.copilot.eclipse.core.lsp.protocol.ConversationModesParams;
+
+@ExtendWith(MockitoExtension.class)
+class BuiltInChatModeServiceTests {
+
+  @Mock
+  private CopilotLanguageServerConnection mockConnection;
+
+  private BuiltInChatModeService builtInChatModeService;
+
+  @BeforeEach
+  void setUp() throws Exception {
+    builtInChatModeService = new BuiltInChatModeService();
+
+    CopilotCore plugin = new CopilotCore();
+    Field languageServerField = CopilotCore.class.getDeclaredField("copilotLanguageServer");
+    languageServerField.setAccessible(true);
+    languageServerField.set(plugin, mockConnection);
+  }
+
+  @Test
+  void testLoadBuiltInModes_inlineAgentSkippedFromAgentModes() {
+    ConversationMode agentMode = createBuiltInMode("Agent", "Agent", "Agent",
+        "Advanced agent mode with access to tools and capabilities");
+    ConversationMode inlineAgentMode = createBuiltInMode("InlineAgent", "Agent", "InlineAgent",
+        "Agent mode with a restricted tool set for inline editing");
+
+    when(mockConnection.listConversationModes(any(ConversationModesParams.class)))
+        .thenReturn(CompletableFuture.completedFuture(new ConversationMode[] { agentMode, inlineAgentMode }));
+
+    List<BuiltInChatMode> builtInModes = builtInChatModeService.loadBuiltInModes().join();
+
+    assertEquals(1, builtInModes.size());
+
+    BuiltInChatMode builtInMode = builtInModes.get(0);
+    assertNotNull(builtInMode);
+    assertEquals("Agent", builtInMode.getId());
+    assertEquals("Agent", builtInMode.getDisplayName());
+    assertEquals("Agent", builtInMode.getKind());
+  }
+
+  private ConversationMode createBuiltInMode(String id, String name, String kind, String description) {
+    ConversationMode mode = new ConversationMode();
+    mode.setId(id);
+    mode.setName(name);
+    mode.setKind(kind);
+    mode.setBuiltIn(true);
+    mode.setDescription(description);
+    return mode;
+  }
+}

com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/chat/BuiltInChatMode.java

@@ -25,6 +25,11 @@ public class BuiltInChatMode extends BaseChatMode {
   public static final String PLAN_MODE_NAME = "Plan";
   public static final String DEBUGGER_MODE_NAME = "Debugger";
 
+  // Built-in mode kinds
+  public static final String INLINE_AGENT_KIND = "InlineAgent";
+
+  private final String kind;
+
   /**
    * Constructor that creates a BuiltInChatMode from a ConversationMode.
    *
@@ -33,6 +38,16 @@ public class BuiltInChatMode extends BaseChatMode {
   public BuiltInChatMode(ConversationMode mode) {
     super(mode.getId(), mode.getName(), mode.getDescription(),
         mode.getCustomTools(), mode.getModel(), mode.getHandOffs());
+    this.kind = mode.getKind();
+  }
+
+  /**
+   * Get the kind of this built-in mode.
+   *
+   * @return the mode kind (e.g., "Ask", "Agent", "InlineAgent")
+   */
+  public String getKind() {
+    return kind;
   }
 
   /**

com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/chat/service/BuiltInChatModeService.java

@@ -41,7 +41,10 @@ public CompletableFuture<List<BuiltInChatMode>> loadBuiltInModes() {
         if (mode == null || !mode.isBuiltIn()) {
           continue;
         }
-
+        // Exclude InlineAgent kind — it is not a user-facing chat mode
+        if (BuiltInChatMode.INLINE_AGENT_KIND.equalsIgnoreCase(mode.getKind())) {
+          continue;
+        }
         // Filter to only allowed built-in modes by name (case-insensitive)
         if (ALLOWED_BUILTIN_NAMES.stream().anyMatch(name -> name.equalsIgnoreCase(mode.getName()))) {
           BuiltInChatMode builtIn = convertToBuiltInChatMode(mode);