Skip to content

Commit 87cb616

Browse files
mtnygardweavejester
authored andcommitted
Separate name and id for radio buttons. Needed for good Javascript addressing.
1 parent f592754 commit 87cb616

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

src/compojure/html/form_helpers.clj

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -68,14 +68,14 @@
6868

6969
(defn radio-button
7070
"Creates a radio button."
71-
([name]
72-
(radio-button name (*params* name)))
73-
([name checked?]
74-
(radio-button name checked? "true"))
75-
([name checked? value]
71+
([id]
72+
(radio-button id (*params* id)))
73+
([id checked?]
74+
(radio-button id checked? "true"))
75+
([id checked? value]
7676
[:input {:type "radio"
77-
:name (str* name)
78-
:id (str* name)
77+
:name (str* id "_" value)
78+
:id (str* id)
7979
:value value
8080
:checked checked?}]))
8181

test/compojure/html/form_helpers.clj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,15 +35,15 @@
3535
(is (= (radio-button :foo)
3636
[:input {:type "radio"
3737
:id "foo"
38-
:name "foo"
38+
:name "foo_true"
3939
:value "true"
4040
:checked nil}])))
4141

4242
(deftest test-radio-button-selected
4343
(is (= (radio-button :foo true "abcdef")
4444
[:input {:type "radio"
4545
:id "foo"
46-
:name "foo"
46+
:name "foo_abcdef"
4747
:value "abcdef"
4848
:checked true}])))
4949

0 commit comments

Comments
 (0)