Skip to content

Commit fa6243e

Browse files
committed
fix visual tests: use single snapshot set with higher tolerance
Drop platform-specific snapshot directories and the useless --update-snapshots CI step. Use a single set of snapshots with maxDiffPixelRatio of 0.15 to account for cross-platform canvas rendering differences (Linux vs macOS use different graphics stacks for sub-pixel antialiasing on rotated images).
1 parent c0876ca commit fa6243e

12 files changed

Lines changed: 2 additions & 7 deletions

.github/workflows/test.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,5 @@ jobs:
5252
- name: Install Playwright browsers
5353
run: pnpm --filter react-avatar-editor exec playwright install --with-deps chromium
5454

55-
- name: Generate visual snapshots (if missing for this platform)
56-
run: pnpm --filter react-avatar-editor exec playwright test --update-snapshots
57-
continue-on-error: true
58-
5955
- name: Visual regression tests
6056
run: pnpm --filter react-avatar-editor exec playwright test

packages/lib/playwright.config.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,10 @@ export default defineConfig({
1212
expect: {
1313
timeout: 10000,
1414
toMatchSnapshot: {
15-
maxDiffPixelRatio: 0.05,
15+
maxDiffPixelRatio: 0.15,
1616
},
1717
},
18-
snapshotPathTemplate:
19-
'{testDir}/__screenshots__/{testFilePath}/{platform}/{arg}{ext}',
18+
snapshotPathTemplate: '{testDir}/__screenshots__/{testFilePath}/{arg}{ext}',
2019
projects: [
2120
{
2221
name: 'chromium',

packages/lib/tests/__screenshots__/canvas.test.ts/darwin/canvas-renders-correctly-at-default-settings-1.png renamed to packages/lib/tests/__screenshots__/canvas.test.ts/canvas-renders-correctly-at-default-settings-1.png

File renamed without changes.

packages/lib/tests/__screenshots__/canvas.test.ts/darwin/canvas-updates-on-resize-1.png renamed to packages/lib/tests/__screenshots__/canvas.test.ts/canvas-updates-on-resize-1.png

File renamed without changes.
125 KB
Loading

packages/lib/tests/__screenshots__/canvas.test.ts/darwin/canvas-updates-on-rotation-180-1.png renamed to packages/lib/tests/__screenshots__/canvas.test.ts/canvas-updates-on-rotation-180-1.png

File renamed without changes.
122 KB
Loading

packages/lib/tests/__screenshots__/canvas.test.ts/darwin/canvas-updates-on-zoom-1.png renamed to packages/lib/tests/__screenshots__/canvas.test.ts/canvas-updates-on-zoom-1.png

File renamed without changes.

packages/lib/tests/__screenshots__/canvas.test.ts/darwin/canvas-updates-with-border-radius-1.png renamed to packages/lib/tests/__screenshots__/canvas.test.ts/canvas-updates-with-border-radius-1.png

File renamed without changes.
Binary file not shown.

0 commit comments

Comments
 (0)