fix: compose cache key with class and fields length (#102)

Author: dead-horse

lib/v2/decoder.js

@@ -519,17 +519,20 @@ var INNER_CLASS_LABEL = '$$ignore_inner_property$$';
 
 proto._readObjectDefinition = function () {
   var classname = this.readString();
+  var fieldsLength = this.readInt();
+  // compose cache key with class name and fields length
+  // more safely
+  var cachekey = classname + '##' + fieldsLength;
 
   // get class definition from cache
-  var cacheClz = this.classCache && this.classCache.get(classname);
+  var cacheClz = this.classCache && this.classCache.get(cachekey);
   if (cacheClz) {
     this.byteBuffer.skip(cacheClz.length);
     this.classes.push(cacheClz);
     return cacheClz;
   }
 
   var pos = this.byteBuffer.position();
-  var fieldsLength = this.readInt();
   var fields = [];
   for (var i = 0; i < fieldsLength; i++) {
     var name = this.readString();
@@ -548,7 +551,7 @@ proto._readObjectDefinition = function () {
   this.classes.push(clz);
   // set class definition into cache
   if (this.classCache) {
-    this.classCache.set(clz.name, clz);
+    this.classCache.set(cachekey, clz);
   }
   return clz;
 };

test/v2.decode.cache.test.js

@@ -117,7 +117,7 @@ describe('v2.decode.cache.test.js', function () {
         ]);
       });
 
-      it('should write "{$class: "hessian.test.demo.Car", $: {a: 1}}"', function () {
+      it('should write "{$class: "hessian.test.demo.Car", $: {a: 1, b: "map"}}"', function () {
         var obj = {
           $class: 'hessian.test.demo.Car',
           $: {a: 1, b: 'map'}
@@ -128,6 +128,17 @@ describe('v2.decode.cache.test.js', function () {
         assert.deepEqual(hessian.decode(buf, '2.0', true), obj);
       });
 
+      it('should write "{$class: "hessian.test.demo.Car", $: {a: 1, b: "map", c: 2}}"', function () {
+        var obj = {
+          $class: 'hessian.test.demo.Car',
+          $: {a: 1, b: 'map', c: 2}
+        };
+        var buf = hessian.encode(obj, '2.0');
+        assert(buf[0] === 0x43);
+        assert.deepEqual(hessian.decode(buf, '2.0'), obj.$);
+        assert.deepEqual(hessian.decode(buf, '2.0', true), obj);
+      });
+
       it('should read one car list', function () {
         assert.deepEqual(hessian.decode(utils.bytes('v2/map/one_car_list'), '2.0'), [
           { a: 'a',