Skip to content

Commit facd71e

Browse files
committed
quic: remove unused env_ variable in session_manager.h/cc
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #63177 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 187b4d3 commit facd71e

3 files changed

Lines changed: 3 additions & 9 deletions

File tree

src/quic/bindingdata.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ BindingData::BindingData(Realm* realm, Local<Object> object)
225225

226226
SessionManager& BindingData::session_manager() {
227227
if (!session_manager_) {
228-
session_manager_ = std::make_unique<SessionManager>(env());
228+
session_manager_ = std::make_unique<SessionManager>();
229229
}
230230
return *session_manager_;
231231
}

src/quic/session_manager.cc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,6 @@
1010

1111
namespace node::quic {
1212

13-
SessionManager::SessionManager(Environment* env) : env_(env) {}
14-
15-
SessionManager::~SessionManager() = default;
16-
1713
BaseObjectPtr<Session> SessionManager::FindSession(const CID& cid) {
1814
// Direct SCID match.
1915
auto it = sessions_.find(cid);

src/quic/session_manager.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ class Session;
2424
// It is not exposed to JavaScript.
2525
class SessionManager final {
2626
public:
27-
explicit SessionManager(Environment* env);
28-
~SessionManager();
27+
explicit SessionManager() = default;
28+
~SessionManager() = default;
2929

3030
// Session routing. The sessions_ map holds BaseObjectPtr<Session> (owning
3131
// references). SessionManager is the single authority for session ownership.
@@ -78,8 +78,6 @@ class SessionManager final {
7878
bool is_empty() const;
7979

8080
private:
81-
Environment* env_;
82-
8381
// The sessions_ map holds strong owning references keyed by locally-
8482
// generated SCIDs. This is the single source of truth for session
8583
// ownership.

0 commit comments

Comments
 (0)