fix: Endpoints from args and config are combined (#6)

Author: Niko Lehtovirta

src/lib/monitoring/config.spec.ts

@@ -51,3 +51,44 @@ test('add endpoint', async t => {
   await conf.setPagerDutyEndpoint(args);
   t.is(conf.getConfig().custom.snsTopic?.critical?.endpoints?.length, 1);
 });
+
+test('Combine earlier endpoints', async t => {
+  const args = {
+    config: 'test',
+    service: ['lambda'],
+    stage: 'dev',
+    endpoints: ['https://events.pagerduty.com/integration/abcb/enqueue'],
+    include: [],
+    exclude: [],
+    dry: true,
+    verbose: false,
+  };
+  const conf = new config.ConfigGenerator(args);
+  await conf.setPagerDutyEndpoint(args);
+
+  // Add second endpoint
+  args.endpoints = ['https://events.pagerduty.com/integration/abcb/enqueue2'];
+  await conf.setPagerDutyEndpoint(args);
+
+  t.is(conf.getConfig().custom.snsTopic?.critical?.endpoints?.length, 2);
+});
+
+test('Combine earlier endpoints should filter out same endpoints', async t => {
+  const args = {
+    config: 'test',
+    service: ['lambda'],
+    stage: 'dev',
+    endpoints: ['https://events.pagerduty.com/integration/abcb/enqueue'],
+    include: [],
+    exclude: [],
+    dry: true,
+    verbose: false,
+  };
+  const conf = new config.ConfigGenerator(args);
+  await conf.setPagerDutyEndpoint(args);
+
+  // Add same endpoints again
+  await conf.setPagerDutyEndpoint(args);
+
+  t.is(conf.getConfig().custom.snsTopic?.critical?.endpoints?.length, 1);
+});

src/lib/monitoring/config.ts

@@ -90,7 +90,7 @@ export class ConfigGenerator {
         );
         const newTopic = {
           ...topic,
-          endpoints: endpoints.filter(e => e) as string[],
+          endpoints: [...new Set([...(topic.endpoints || []), ...endpoints].filter(e => e))] as string[],
         };
         return [topicKey, newTopic];
       }),