Skip to content

Commit aefa877

Browse files
committed
Do not run omc with shell=True
1 parent 18142a1 commit aefa877

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

OMPython/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ def _start_omc_process(self, timeout):
188188
my_env = os.environ.copy()
189189
my_env["USER"] = self._currentUser
190190
# Because we spawned a shell, and we need to be able to kill OMC, create a new process group for this
191-
self._omc_process = subprocess.Popen(self._omc_command, shell=True, stdout=self._omc_log_file, stderr=self._omc_log_file, env=my_env, preexec_fn=os.setsid)
191+
self._omc_process = subprocess.Popen(self._omc_command, stdout=self._omc_log_file, stderr=self._omc_log_file, env=my_env, preexec_fn=os.setsid)
192192
if self._docker:
193193
for i in range(0, 40):
194194
try:
@@ -276,7 +276,7 @@ def _set_omc_command(self, omc_path_and_args_list):
276276
if sys.platform == 'win32':
277277
self._omc_command = omc_path_and_args_list
278278
else:
279-
self._omc_command = ' '.join([shlex.quote(a) for a in omc_path_and_args_list])
279+
self._omc_command = [shlex.quote(a) for a in omc_path_and_args_list]
280280

281281
return self._omc_command
282282

0 commit comments

Comments
 (0)