In result of static analyse of nginx sources (including headers-more-nginx-module) with Svace static analyzer I found minor error of cathegory "REDUNDANT_COMPARISON.ALWAYS_FALSE" in ngx_http_headers_more_filter_module.c.
|
if (multi_http_blocks || hmcf->requires_filter) { |
|
rc = ngx_http_headers_more_filter_init(cf); |
|
if (rc != NGX_OK) { |
|
return rc; |
|
} |
|
} |
calling function ngx_http_headers_more_filter_init returns NGX_OK code only. Is it correct to check it there?
In result of static analyse of nginx sources (including headers-more-nginx-module) with Svace static analyzer I found minor error of cathegory "REDUNDANT_COMPARISON.ALWAYS_FALSE" in ngx_http_headers_more_filter_module.c.
headers-more-nginx-module/src/ngx_http_headers_more_filter_module.c
Lines 234 to 239 in f8f8099
calling function
ngx_http_headers_more_filter_initreturnsNGX_OKcode only. Is it correct to check it there?