#224 Make use of unit IDs as translation IDs optional

Author: asmecher

src/Extractors/Xliff.php

@@ -11,11 +11,18 @@
  */
 class Xliff extends Extractor implements ExtractorInterface
 {
+
+    public static $options = [
+        'unitid_as_id' => false
+    ];
+
     /**
      * {@inheritdoc}
      */
     public static function fromString($string, Translations $translations, array $options = [])
     {
+        $options += static::$options;
+
         $xml = new SimpleXMLElement($string, null, false);
 
         foreach ($xml->file as $file) {
@@ -37,7 +44,9 @@ public static function fromString($string, Translations $translations, array $op
                     if (isset($unit['id'])) {
                         $unitId = (string) $unit['id'];
                         $translation->addComment("XLIFF_UNIT_ID: $unitId");
-                        $translation->setId($unitId);
+                        if ($options['unitid_as_id']) {
+                            $translation->setId($unitId);
+                        }
                     }
                     $translation->setTranslation(array_shift($targets));
                     $translation->setPluralTranslations($targets);

tests/AssetsTest.php

@@ -548,9 +548,9 @@ public function testVueJs2MultipleDomainScanning()
         }
     }
 
-    public function testXliff()
+    public function testXliffUnitIds()
     {
-        $translations = static::get('xliff/Xliff', 'Xliff');
+        $translations = static::get('xliff/Xliff', 'Xliff', ['unitid_as_id' => true]);
         $countTranslations = 3;
         $countTranslated = 3;
         $countHeaders = 9;