Skip to content

Commit 854ff5f

Browse files
committed
Fixed javascript parser #187
1 parent cb08ec5 commit 854ff5f

14 files changed

Lines changed: 44 additions & 2 deletions

CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
77

88
Previous releases are documented in [github releases](https://github.com/oscarotero/Gettext/releases)
99

10+
## [4.6.1] - 2018-08-27
11+
12+
### Fixed
13+
14+
- VueJS DOM parsing [#188]
15+
- Javascript parser was unable to extract some functions [#187]
16+
1017
## [4.6.0] - 2018-06-26
1118

1219
### Added
@@ -93,6 +100,8 @@ Previous releases are documented in [github releases](https://github.com/oscarot
93100

94101
- Fixed a bug related with the javascript source extraction with single quotes
95102

103+
[#188]: https://github.com/oscarotero/Gettext/issues/188
104+
[#187]: https://github.com/oscarotero/Gettext/issues/187
96105
[#178]: https://github.com/oscarotero/Gettext/issues/178
97106
[#182]: https://github.com/oscarotero/Gettext/issues/182
98107
[#177]: https://github.com/oscarotero/Gettext/issues/177
@@ -112,6 +121,7 @@ Previous releases are documented in [github releases](https://github.com/oscarot
112121
[#145]: https://github.com/oscarotero/Gettext/issues/145
113122
[#146]: https://github.com/oscarotero/Gettext/issues/146
114123

124+
[4.6.1]: https://github.com/oscarotero/Gettext/compare/v4.6.0...v4.6.1
115125
[4.6.0]: https://github.com/oscarotero/Gettext/compare/v4.5.0...v4.6.0
116126
[4.5.0]: https://github.com/oscarotero/Gettext/compare/v4.4.4...v4.5.0
117127
[4.4.4]: https://github.com/oscarotero/Gettext/compare/v4.4.3...v4.4.4

src/Utils/JsFunctionsScanner.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,7 @@ public function getFunctions(array $constants = [])
165165
break;
166166

167167
default:
168+
$buffer = '';
168169
continue 3;
169170
}
170171
break;

tests/AssetsTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ public function testJsCode()
232232
public function testJs2Code()
233233
{
234234
$translations = static::get('jscode2/input', 'JsCode');
235-
$countTranslations = 3;
235+
$countTranslations = 4;
236236
$countTranslated = 0;
237237
$countHeaders = 8;
238238

tests/assets/jscode2/Csv.csv

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,4 @@ Report-Msgid-Bugs-To:
1010
,"some message",
1111
"some context","some message in a context",
1212
,"%s message",
13+
,"my translate 3",
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
"some message",
22
"some message in a context",
33
"%s message",
4+
"my translate 3",

tests/assets/jscode2/Jed.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@
1313
],
1414
"%s message": [
1515
""
16+
],
17+
"my translate 3": [
18+
""
1619
]
1720
}
1821
}

tests/assets/jscode2/Json.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@
1111
],
1212
"%s message": [
1313
""
14+
],
15+
"my translate 3": [
16+
""
1417
]
1518
},
1619
"some context": {
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"some message": "",
33
"some message in a context": "",
4-
"%s message": ""
4+
"%s message": "",
5+
"my translate 3": ""
56
}

tests/assets/jscode2/PhpArray.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,10 @@
2525
array (
2626
0 => '',
2727
),
28+
'my translate 3' =>
29+
array (
30+
0 => '',
31+
),
2832
),
2933
'some context' =>
3034
array (

tests/assets/jscode2/Po.po

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,3 +22,7 @@ msgstr ""
2222
msgid "%s message"
2323
msgid_plural "%s messages"
2424
msgstr[0] ""
25+
26+
#: ./tests/assets/jscode2/input.js:8
27+
msgid "my translate 3"
28+
msgstr ""

0 commit comments

Comments
 (0)