Merge pull request #238 from briedis/fix-domain-issue

Fix PHP error when scanning for single domain, but other strings found.

Author: Oscar Otero

src/Utils/FunctionsScanner.php

@@ -70,7 +70,7 @@ public function saveGettextFunctions($translations, array $options)
                 continue;
             }
 
-            if (!$isDefaultDomain && !$domainTranslations) {
+            if (!$domainTranslations) {
                 continue;
             }
 

tests/AssetsTest.php

@@ -548,6 +548,15 @@ public function testVueJs2MultipleDomainScanning()
         }
     }
 
+    public function testMissingDomainScanWithOtherStringsInFile()
+    {
+        $translations = (new Translations())->setDomain('unknown-domain');
+
+        PhpCode::fromFileMultiple(static::asset('phpcode6/input.php'), [$translations]);
+
+        self::assertCount(0, $translations);
+    }
+
     public function testXliffUnitIds()
     {
         $translations = static::get('xliff/Xliff', 'Xliff', ['unitid_as_id' => true]);
@@ -580,6 +589,6 @@ public function testXliffUnitIds()
 
         // Converting from an XLIFF that contains duplicate <source> elements
         // to a PO file will result in the loss of the duplicates.
-        $this->runTestFormat('xliff/Po', $countTranslations-1, $countTranslated-1, $countHeaders);
+        $this->runTestFormat('xliff/Po', $countTranslations - 1, $countTranslated - 1, $countHeaders);
     }
 }

tests/assets/phpcode6/input.php

@@ -0,0 +1,6 @@
+<?php
+
+pgettext('context', 'Text with context');
+_('No domain text');
+
+dgettext('other', 'Other domain text');