version_compare: Fix handling of version numbers with a trailing dot

Author: TimWolla

ext/standard/tests/versioning/version_compare.phpt

@@ -22,6 +22,9 @@ foreach ($special_forms as $f1) {
     test("1.0$f1", "1.0$f2");
     }
 }
+test("1.2.", "1.2.");
+test("1.2..", "1.2..");
+
 print "TESTING OPERATORS\n";
 foreach ($special_forms as $f1) {
     foreach ($special_forms as $f2) {
@@ -106,6 +109,8 @@ TESTING COMPARE
 1.0pl1 > 1.0rc1
 1.0pl1 > 1.0
 1.0pl1 = 1.0pl1
+1.2. = 1.2.
+1.2.. = 1.2..
 TESTING OPERATORS
 1.0-dev lt 1.0-dev : false
 1.0-dev  < 1.0-dev : false

ext/standard/versioning.c

@@ -68,7 +68,15 @@ php_canonicalize_version(const char *version)
 		}
 		lp = *p++;
 	}
-	*q++ = '\0';
+
+	/* Check if the last component is empty (i.e. the last character is a dot)
+	 * and remove it if it is. */
+	if (*(q - 1) == '.') {
+		*(q - 1) = '\0';
+	} else {
+		*q = '\0';
+	}
+
 	return buf;
 }
 
@@ -178,7 +186,7 @@ php_version_compare(const char *orig_ver1, const char *orig_ver2)
 			p2 = n2 + 1;
 		}
 	}
-	if (compare == 0) {
+	if (compare == 0 && (*p1 || *p2)) {
 		if (n1 != NULL) {
 			if (isdigit(*p1)) {
 				compare = 1;