make ProcessResult class readonly

Author: mvorisek

benchmark/shared.php

@@ -1,14 +1,15 @@
 <?php
 
-class ProcessResult {
-    public $stdout;
-    public $stderr;
+readonly class ProcessResult {
+    public function __construct(
+        public string $stdout,
+        public string $stderr,
+    ) {}
 }
 
 function runCommand(array $args, ?string $cwd = null, bool $printCommand = true): ProcessResult {
     $cmd = implode(' ', array_map('escapeshellarg', $args));
     $pipes = null;
-    $result = new ProcessResult();
     $descriptorSpec = [0 => ['pipe', 'r'], 1 => ['pipe', 'w'], 2 => ['pipe', 'w']];
     if ($printCommand) {
         fwrite(STDOUT, "> $cmd\n");
@@ -24,6 +25,8 @@ function runCommand(array $args, ?string $cwd = null, bool $printCommand = true)
     stream_set_blocking($stdout, false);
     stream_set_blocking($stderr, false);
 
+    $stdoutStr = '';
+    $stderrStr = '';
     $stdoutEof = false;
     $stderrEof = false;
 
@@ -37,9 +40,9 @@ function runCommand(array $args, ?string $cwd = null, bool $printCommand = true)
         foreach ($read as $stream) {
             $chunk = fgets($stream);
             if ($stream === $stdout) {
-                $result->stdout .= $chunk;
+                $stdoutStr .= $chunk;
             } elseif ($stream === $stderr) {
-                $result->stderr .= $chunk;
+                $stderrStr .= $chunk;
             }
         }
 
@@ -50,6 +53,8 @@ function runCommand(array $args, ?string $cwd = null, bool $printCommand = true)
     fclose($stdout);
     fclose($stderr);
 
+    $result = new ProcessResult($stdoutStr, $stderrStr);
+
     $statusCode = proc_close($processHandle);
     if ($statusCode !== 0) {
         fwrite(STDOUT, $result->stdout);