main/output.c: use RETURN_BOOL() when possible

Girgias · Girgias · commit e5edab2f4270 · 2026-04-06T19:11:40.000+01:00
diff --git a/main/output.c b/main/output.c
@@ -1577,11 +1577,7 @@ PHP_FUNCTION(output_reset_rewrite_vars)
 {
 	ZEND_PARSE_PARAMETERS_NONE();
 
-	if (php_url_scanner_reset_vars() == SUCCESS) {
-		RETURN_TRUE;
-	} else {
-		RETURN_FALSE;
-	}
+	RETURN_BOOL(php_url_scanner_reset_vars() == SUCCESS);
 }
 /* }}} */
 
@@ -1595,10 +1591,6 @@ PHP_FUNCTION(output_add_rewrite_var)
 		RETURN_THROWS();
 	}
 
-	if (php_url_scanner_add_var(name, name_len, value, value_len, 1) == SUCCESS) {
-		RETURN_TRUE;
-	} else {
-		RETURN_FALSE;
-	}
+	RETURN_BOOL(php_url_scanner_add_var(name, name_len, value, value_len, 1) == SUCCESS);
 }
 /* }}} */

Original file line number	Diff line number	Diff line change
`@@ -1577,11 +1577,7 @@ PHP_FUNCTION(output_reset_rewrite_vars)`
`1577`	`1577`	`{`
`1578`	`1578`	`ZEND_PARSE_PARAMETERS_NONE();`
`1579`	`1579`
`1580`		`- if (php_url_scanner_reset_vars() == SUCCESS) {`
`1581`		`- RETURN_TRUE;`
`1582`		`- } else {`
`1583`		`- RETURN_FALSE;`
`1584`		`- }`
	`1580`	`+ RETURN_BOOL(php_url_scanner_reset_vars() == SUCCESS);`
`1585`	`1581`	`}`
`1586`	`1582`	`/* }}} */`
`1587`	`1583`
`@@ -1595,10 +1591,6 @@ PHP_FUNCTION(output_add_rewrite_var)`
`1595`	`1591`	`RETURN_THROWS();`
`1596`	`1592`	`}`
`1597`	`1593`
`1598`		`- if (php_url_scanner_add_var(name, name_len, value, value_len, 1) == SUCCESS) {`
`1599`		`- RETURN_TRUE;`
`1600`		`- } else {`
`1601`		`- RETURN_FALSE;`
`1602`		`- }`
	`1594`	`+ RETURN_BOOL(php_url_scanner_add_var(name, name_len, value, value_len, 1) == SUCCESS);`
`1603`	`1595`	`}`
`1604`	`1596`	`/* }}} */`