Inline one-line wrappers around polymorphic Type methods

Follow-up cleanup across #5611, #5612, #5613:

- `FuncCallHandler::getArrayWalkResultType()` and
  `getArraySortDoNotPreserveListFunctionType()` were single-statement
  wrappers around `Type::mapValueType()` / `Type::makeListMaybe()`.
  Both private, both fully replaced by their polymorphic call;
  inline at the two/one call sites and delete the helpers.
- `InstanceofHandler` and `TypeSpecifier` (the `instanceof <expr>`
  branch) used a throwaway `$classType = $scope->getType(...)` only
  to immediately overwrite it with `$result->type`. Drop the
  intermediate; chain the call.

Pure simplification: full test suite + phpstan + cs pass.

Author: ondrejmirtes

src/Analyser/ExprHandler/FuncCallHandler.php

@@ -273,8 +273,10 @@ public function processExpr(NodeScopeResolver $nodeScopeResolver, Stmt $stmt, Ex
 		$isAlwaysTerminating = $isAlwaysTerminating || $argsResult->isAlwaysTerminating();
 
 		if ($arrayWalkValueTypes !== null && $arrayWalkArrayArg !== null) {
-			$newArrayType = $this->getArrayWalkResultType($arrayWalkOriginalArrayType, $arrayWalkValueTypes[0]);
-			$newArrayNativeType = $this->getArrayWalkResultType($arrayWalkOriginalArrayNativeType, $arrayWalkValueTypes[1]);
+			$arrayWalkValueType = $arrayWalkValueTypes[0];
+			$arrayWalkValueNativeType = $arrayWalkValueTypes[1];
+			$newArrayType = $arrayWalkOriginalArrayType->mapValueType(static fn (Type $type): Type => $arrayWalkValueType);
+			$newArrayNativeType = $arrayWalkOriginalArrayNativeType->mapValueType(static fn (Type $type): Type => $arrayWalkValueNativeType);
 
 			$scope = $nodeScopeResolver->processVirtualAssign(
 				$scope,
@@ -478,7 +480,7 @@ public function processExpr(NodeScopeResolver $nodeScopeResolver, Stmt $stmt, Ex
 				$storage,
 				$stmt,
 				$arrayArg,
-				new NativeTypeExpr($this->getArraySortDoNotPreserveListFunctionType($scope->getType($arrayArg)), $this->getArraySortDoNotPreserveListFunctionType($scope->getNativeType($arrayArg))),
+				new NativeTypeExpr($scope->getType($arrayArg)->makeListMaybe(), $scope->getNativeType($arrayArg)->makeListMaybe()),
 				$nodeCallback,
 			)->getScope();
 		}
@@ -721,16 +723,6 @@ static function (?Type $offsetType, Type $valueType, bool $optional) use (&$arra
 		return $arrayType;
 	}
 
-	private function getArraySortDoNotPreserveListFunctionType(Type $type): Type
-	{
-		return $type->makeListMaybe();
-	}
-
-	private function getArrayWalkResultType(Type $arrayType, Type $newValueType): Type
-	{
-		return $arrayType->mapValueType(static fn (Type $type): Type => $newValueType);
-	}
-
 	public function resolveType(MutatingScope $scope, Expr $expr): Type
 	{
 		if ($expr->name instanceof Expr) {

src/Analyser/ExprHandler/InstanceofHandler.php

@@ -91,8 +91,7 @@ public function resolveType(MutatingScope $scope, Expr $expr): Type
 				$classType = new ObjectType($className);
 			}
 		} else {
-			$classType = $scope->getType($expr->class);
-			$result = $classType->toObjectTypeForInstanceofCheck();
+			$result = $scope->getType($expr->class)->toObjectTypeForInstanceofCheck();
 			$classType = $result->type;
 			$uncertainty = $result->uncertainty;
 		}

src/Analyser/TypeSpecifier.php

@@ -164,8 +164,7 @@ public function specifyTypesInCondition(
 				return $this->create($exprNode, $type, $context, $scope)->setRootExpr($expr);
 			}
 
-			$classType = $scope->getType($expr->class);
-			$result = $classType->toObjectTypeForInstanceofCheck();
+			$result = $scope->getType($expr->class)->toObjectTypeForInstanceofCheck();
 			$type = $result->type;
 			$uncertainty = $result->uncertainty;