Test result-cache restore does not trigger reflection (#5617)

Co-authored-by: Petr Morávek <petr@pada.cz>

Author: staabm

.github/workflows/e2e-tests.yml

@@ -307,6 +307,11 @@ jobs:
               echo "$OUTPUT"
               ../bashunit -a matches "Note: Using configuration file .+phpstan.neon." "$OUTPUT"
               ../bashunit -a contains 'Result cache not used because the metadata do not match: metaExtensions' "$OUTPUT"
+          - script: |
+              cd e2e/result-cache-restore-without-reflection
+              composer install
+              ../../bin/phpstan -vvv
+              ../../bin/phpstan -vvv
           - script: |
               cd e2e/bug-12606
               export CONFIGTEST=test

e2e/result-cache-restore-without-reflection/.gitignore

@@ -0,0 +1,2 @@
+/vendor
+composer.lock

e2e/result-cache-restore-without-reflection/composer.json

@@ -0,0 +1,17 @@
+{
+    "require-dev": {
+        "phpstan/phpstan-symfony": "@dev",
+        "phpstan/extension-installer": "^1.4",
+        "phpstan/phpstan-doctrine": "@dev"
+    },
+	"autoload": {
+		"classmap": [
+			"lib/"
+		]
+	},
+    "config": {
+        "allow-plugins": {
+            "phpstan/extension-installer": true
+        }
+    }
+}

e2e/result-cache-restore-without-reflection/lib/ThrowingSourceLocator.php

@@ -0,0 +1,25 @@
+<?php declare(strict_types = 1);
+
+namespace E2EFixture;
+
+use LogicException;
+use PHPStan\BetterReflection\Identifier\Identifier;
+use PHPStan\BetterReflection\Identifier\IdentifierType;
+use PHPStan\BetterReflection\Reflection\Reflection;
+use PHPStan\BetterReflection\Reflector\Reflector;
+use PHPStan\BetterReflection\SourceLocator\Type\SourceLocator;
+
+final class ThrowingSourceLocator implements SourceLocator
+{
+
+	public function locateIdentifier(Reflector $reflector, Identifier $identifier): ?Reflection
+	{
+		throw new LogicException('SourceLocator::locateIdentifier must not be called during result cache construction');
+	}
+
+	public function locateIdentifiersByType(Reflector $reflector, IdentifierType $identifierType): array
+	{
+		throw new LogicException('SourceLocator::locateIdentifiersByType must not be called during result cache construction');
+	}
+
+}

e2e/result-cache-restore-without-reflection/phpstan.neon

@@ -0,0 +1,10 @@
+parameters:
+	level: 8
+	paths:
+		- src
+
+services:
+	betterReflectionSourceLocator:
+		class: PHPStan\BetterReflection\SourceLocator\Type\SourceLocator
+		factory: E2EFixture\ThrowingSourceLocator
+		autowired: false

e2e/result-cache-restore-without-reflection/src/foo.php

@@ -0,0 +1,4 @@
+<?php
+
+echo "";
+