Fix PHPStorm inspection errors

Author: staabm

src/Analyser/NodeScopeResolver.php

@@ -1910,7 +1910,7 @@ private function processStmtNode(
 							continue;
 						}
 
-						foreach ($catchTypes as $catchTypeIndex => $catchTypeItem) {
+						foreach ($catchTypes as $catchTypeItem) {
 							if ($catchTypeItem->isSuperTypeOf($throwPoint->getType())->no()) {
 								continue;
 							}
@@ -6393,7 +6393,7 @@ private function processAssignVar(
 					$throwPoints = array_merge($throwPoints, $keyResult->getThrowPoints());
 					$impurePoints = array_merge($impurePoints, $keyResult->getImpurePoints());
 					$isAlwaysTerminating = $isAlwaysTerminating || $keyResult->isAlwaysTerminating();
-					$itemScope = $keyResult->getScope();
+					// no need for $keyResult->getScope()
 				}
 
 				if ($arrayItem->key === null) {

src/PhpDoc/StubValidator.php

@@ -133,7 +133,7 @@ public function validate(array $stubFiles, bool $debug): array
 			]);
 
 			$ruleRegistry = $this->getRuleRegistry($container);
-			$collectorRegistry = $this->getCollectorRegistry($container);
+			$collectorRegistry = $this->getCollectorRegistry();
 
 			$fileAnalyser = $container->getByType(FileAnalyser::class);
 
@@ -293,7 +293,7 @@ private function getRuleRegistry(Container $container): RuleRegistry
 		return new DirectRuleRegistry($rules);
 	}
 
-	private function getCollectorRegistry(Container $container): CollectorRegistry
+	private function getCollectorRegistry(): CollectorRegistry
 	{
 		return new CollectorRegistry([]);
 	}

src/Rules/PhpDoc/WrongVariableNameInVarTagRule.php

@@ -101,7 +101,7 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		if ($node instanceof Node\Stmt\Global_) {
-			return $this->processGlobal($scope, $node, $varTags);
+			return $this->processGlobal($node, $varTags);
 		}
 
 		if ($node instanceof InClassNode || $node instanceof InClassMethodNode || $node instanceof InFunctionNode) {
@@ -372,7 +372,7 @@ private function processStmt(Scope $scope, array $varTags, ?Expr $defaultExpr):
 	 * @param VarTag[] $varTags
 	 * @return list<IdentifierRuleError>
 	 */
-	private function processGlobal(Scope $scope, Node\Stmt\Global_ $node, array $varTags): array
+	private function processGlobal(Node\Stmt\Global_ $node, array $varTags): array
 	{
 		$variableNames = [];
 		foreach ($node->vars as $var) {

src/Type/Php/StatDynamicReturnTypeExtension.php

@@ -17,6 +17,7 @@
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeCombinator;
 use SplFileObject;
+use function count;
 use function in_array;
 
 #[AutowiredService]
@@ -68,7 +69,7 @@ private function getReturnType(): Type
 			'blocks',
 		];
 
-		foreach ($keys as $key) {
+		for ($i = 0; $i < count($keys); $i++) {
 			$builder->setOffsetValueType(null, $valueType);
 		}
 

tests/PHPStan/Rules/Methods/data/uppercase-string.php

@@ -28,6 +28,6 @@ public function test(
 		$this->acceptUppercaseString($string);
 		$this->acceptUppercaseString($uppercaseString);
 		$this->acceptUppercaseString($numericString);
-		$this->acceptUppercaseString($nonEmptyLowercaseString);
+		$this->acceptUppercaseString($nonEmptyUppercaseString);
 	}
 }