Skip to content

Commit be010b4

Browse files
committed
artifact upload/download logic
1 parent c0efe53 commit be010b4

2 files changed

Lines changed: 9 additions & 14 deletions

File tree

.github/workflows/publish-dist.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,6 @@ jobs:
4848
- name: Build dist/
4949
run: npm run build
5050

51-
# Upload library uncompressed to allow for testing in REPLs
52-
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
53-
name: Upload uncompressed plotly.js built from PR, using Node 22
54-
with:
55-
retention-days: 30
56-
archive: false
57-
path: dist/plotly.js
58-
5951
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
6052
name: Upload Node 18 archive of plotly.js build folder
6153
with:

.github/workflows/upload-dev-build.yml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
2727
continue-on-error: true
2828
with:
29-
name: plotly.node22.js # uploaded by publish-dist.yml > publish-dist-node-v22
29+
name: dist-node18 # uploaded by publish-dist.yml > publish-dist-node-v22
3030
run-id: ${{ github.event.workflow_run.id || inputs.run_id }}
3131
github-token: ${{ secrets.GITHUB_TOKEN }}
3232
path: temp-dist
@@ -51,11 +51,14 @@ jobs:
5151
echo "Fetching latest SHA for PR #$PR_NUM..."
5252
SHA=$(gh pr view "$PR_NUM" --repo ${{ github.repository }} --json headRefOid --template '{{.headRefOid}}')
5353
fi
54-
55-
echo "Using SHA: $SHA"
56-
cp temp-dist/plotly.node22.js "upload/pr-$PR_NUM/$SHA/plotly.js"
57-
cp temp-dist/plotly.node22.js "upload/pr-$PR_NUM/latest/plotly.js"
58-
54+
55+
echo "Using SHA: $SHA"
56+
mkdir -p "upload/pr-$PR_NUM/$SHA"
57+
cp temp-dist/plotly.js "upload/pr-$PR_NUM/$SHA/plotly.js"
58+
cp temp-dist/plotly.min.js "upload/pr-$PR_NUM/$SHA/plotly.min.js"
59+
cp temp-dist/plot-schema.json "upload/pr-$PR_NUM/$SHA/plot-schema.json"
60+
cp -r "upload/pr-$PR_NUM/$SHA/plotly.js" "upload/pr-$PR_NUM/latest"
61+
5962
echo "PR_NUM=$PR_NUM" >> $GITHUB_OUTPUT
6063
echo "SHA=$SHA" >> $GITHUB_OUTPUT
6164

0 commit comments

Comments
 (0)