refactor: tighten EnumHelper and dedupe rebalancer enum conversion

- type EnumHelper::convertEnumToString param as mixed, mark class final, add strict_types
- split BackedEnum / UnitEnum branches, throw InvalidArgumentException on unknown objects
- convert column ids once inside findColumnsNeedingRebalancing so callers don't re-convert
- update unit test to assert the throw

Author: ManukMinasyan

src/Commands/RebalancePositionsCommand.php

@@ -5,7 +5,6 @@
 use Illuminate\Console\Command;
 use Illuminate\Database\Eloquent\Model;
 use Relaticle\Flowforge\Services\PositionRebalancer;
-use Relaticle\Flowforge\Support\EnumHelper;
 
 use function Laravel\Prompts\confirm;
 use function Laravel\Prompts\error;
@@ -163,9 +162,8 @@ private function rebalanceAllNeeded(
         $this->newLine();
 
         foreach ($columnsNeedingRebalancing as $columnId) {
-            $columnValue = EnumHelper::convertEnumToString($columnId);
-            $stats = $rebalancer->getGapStatistics($query, $columnField, $columnValue, $positionField);
-            $this->line("  - {$columnValue}: {$stats['count']} records, {$stats['small_gaps']} small gaps");
+            $stats = $rebalancer->getGapStatistics($query, $columnField, $columnId, $positionField);
+            $this->line("  - {$columnId}: {$stats['count']} records, {$stats['small_gaps']} small gaps");
         }
 
         $this->newLine();

src/Commands/RepairPositionsCommand.php

@@ -189,7 +189,6 @@ private function analyzePositions(string $model, string $columnField, string $po
             ->groupBy($columnField)
             ->pluck('record_count', $columnField)
             ->mapWithKeys(function ($count, $key) {
-                // Convert enum to string value if needed
                 $stringKey = EnumHelper::convertEnumToString($key);
 
                 return [$stringKey => $count];
@@ -237,7 +236,6 @@ private function calculateChanges(string $model, string $columnField, string $po
             ->pluck($columnField);
 
         foreach ($groups as $group) {
-            // Convert enum to string for array key
             $groupKey = EnumHelper::convertEnumToString($group);
 
             $records = $this->getRecordsForStrategy($model, $columnField, $positionField, $group, $strategy, $query);

src/Services/PositionRebalancer.php

@@ -102,10 +102,11 @@ public function findColumnsNeedingRebalancing(
         $columns = (clone $query)
             ->select($columnField)
             ->distinct()
-            ->pluck($columnField);
+            ->pluck($columnField)
+            ->map(fn ($columnId) => EnumHelper::convertEnumToString($columnId));
 
-        return $columns->filter(function ($columnId) use ($query, $columnField, $positionField) {
-            return $this->needsRebalancing($query, $columnField, EnumHelper::convertEnumToString($columnId), $positionField);
+        return $columns->filter(function (string $columnId) use ($query, $columnField, $positionField) {
+            return $this->needsRebalancing($query, $columnField, $columnId, $positionField);
         })->values();
     }
 
@@ -131,12 +132,10 @@ public function rebalanceAll(
         );
 
         foreach ($columnsNeedingRebalancing as $columnId) {
-            $columnValue = EnumHelper::convertEnumToString($columnId);
-
-            $results[$columnValue] = $this->rebalanceColumn(
+            $results[$columnId] = $this->rebalanceColumn(
                 $query,
                 $columnField,
-                $columnValue,
+                $columnId,
                 $positionField
             );
         }

src/Support/EnumHelper.php

@@ -1,27 +1,38 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Relaticle\Flowforge\Support;
 
-class EnumHelper
+use BackedEnum;
+use InvalidArgumentException;
+use UnitEnum;
+
+final class EnumHelper
 {
-    public static function convertEnumToString($value): string
+    public static function convertEnumToString(mixed $value): string
     {
+        if ($value instanceof BackedEnum) {
+            return (string) $value->value;
+        }
+
+        if ($value instanceof UnitEnum) {
+            return $value->name;
+        }
+
         if (is_object($value)) {
-            // Handle Laravel Enums (implements UnitEnum)
-            if ($value instanceof \UnitEnum) {
-                return $value->value ?? $value->name;
-            }
-            // Handle objects with value property
             if (property_exists($value, 'value')) {
                 return (string) $value->value;
             }
-            // Handle objects with __toString method
+
             if (method_exists($value, '__toString')) {
                 return (string) $value;
             }
 
-            // Fallback: try to get class name or serialize
-            return class_basename($value);
+            throw new InvalidArgumentException(sprintf(
+                'Cannot convert object of type %s to a column identifier string.',
+                $value::class,
+            ));
         }
 
         return (string) $value;

tests/Unit/EnumHelperTest.php

@@ -20,11 +20,11 @@
         expect(EnumHelper::convertEnumToString(42))->toBe('42');
     });
 
-    test('falls back to class basename for unknown objects', function () {
+    test('throws for unknown objects', function () {
         $obj = new class {};
 
-        expect(EnumHelper::convertEnumToString($obj))->toBeString()->not->toBeEmpty();
-    });
+        EnumHelper::convertEnumToString($obj);
+    })->throws(InvalidArgumentException::class);
 
     test('returns value from object with value property', function () {
         $obj = new class