Merge pull request #5 from sensu-plugins/feature/standard-stuff

standard stuff

Author: mickfeech

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,27 @@
+## Pull Request Checklist
+
+**Is this in reference to an existing issue?**
+
+#### General
+
+- [ ] Update Changelog following the conventions laid out [here](https://github.com/sensu-plugins/community/blob/master/HOW_WE_CHANGELOG.md)
+
+- [ ] Update README with any necessary configuration snippets
+
+- [ ] Binstubs are created if needed
+
+- [ ] RuboCop passes
+
+- [ ] Existing tests pass
+
+#### New Plugins
+
+- [ ] Tests
+
+- [ ] Add the plugin to the README
+
+- [ ] Does it have a complete header as outlined [here](http://sensu-plugins.io/docs/developer_guidelines.html#coding-style)
+
+#### Purpose
+
+#### Known Compatibility Issues

.rubocop.yml

@@ -1,29 +1,30 @@
-MethodLength:
-  Max: 200
-
-LineLength:
-  Max: 160
-
-AbcSize:
-  Max: 100
-
-FileName:
-  Enabled: false
-
-PerceivedComplexity:
-  Enabled: false
-
-CyclomaticComplexity:
-  Enabled: false
-
-ClassLength:
-  Enabled: false
-
-IfUnlessModifier:
-  Enabled: false
-
-RegexpLiteral:
-  Enabled: false
-
-Style/Documentation:
-  Enabled: false
+
+MethodLength:
+  Max: 200
+
+LineLength:
+  Max: 160
+
+AbcSize:
+  Max: 100
+
+FileName:
+  Enabled: false
+
+PerceivedComplexity:
+  Enabled: false
+
+CyclomaticComplexity:
+  Enabled: false
+
+ClassLength:
+  Enabled: false
+
+IfUnlessModifier:
+  Enabled: false
+
+RegexpLiteral:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false

.travis.yml

@@ -1,15 +1,36 @@
-language: ruby
-rvm:
-- 2.1
-- 2.2
-- 2.3.0
-before_install:
-- gem update bundler
-deploy:
-  provider: rubygems
-  api_key:
-    secure: fnQYXam9lo9VzmmOZgQjB8C35Vq3E4eWmgHNhmPnHTGWSfkMvk/755CizKkbcA8MLuqGoy5vqqfldGArJD62vfhYqKZhAanFBHBr7OhUfVAhGX3tz2+TQt3FjzFaDGOzoVI6rFO+8tZYLGkeMwmTFXkFgJDdHEi6mpokvFaj35SktF/iYPmwDZhqATMAmnuTVKRxVudJ1HQtX9f+kgb7L35/QcG55CirnXxdueqr6wC/rk4XyzVg7dZLQXjXlo4MQXEMZ1BrLkvpdjcb0y5pET/U1oSuhFSwIv6vvy89yzQvmdDaYhWL9PumPdtC2LVorkv7FZT/vQAzVD7ewPvaFsMoP0CSrik8RImUry+8RLwxhV08n5DOkAiSzTUk+KF1jQ1HTR2v4t+UjFQSW3vg83kgJnR9sDRPHfxVO2/yAVjEmqk+F/Fs+oelf2b+JFrlnJ7fqI/c9wWYYfxiBAR+vhq0iCZEZEyIjLSGba1yQ8xJEW0ncA29ykjXx35w/SIAWqgBFblLIAehZ+m3ep1tCZwoQy8f1WQmx3n5iCXa5fx6d19hCJKfjevprjX/LOGgLdp2aU0mLszyQOF5ORAaR64QKpyBs5pHNLNkapGAUttzjktak9WgEagzu9TTEcBnsCsZgi0h/NaU/egZXM8a+aRQqopIcoMzD5GRB0OI8Og=
-  gem: sensu-plugins-systemd
-  on:
-    tags: true
-    repo: mickfeech/sensu-plugins-systemd
+language: ruby
+cache:
+- bundler
+before_install: gem install bundler -v 1.15
+install:
+- bundle install
+rvm:
+- 2.0
+- 2.1
+- 2.2
+- 2.3.0
+- 2.4.1
+notifications:
+  email:
+    recipients:
+    - sensu-plugin@sensu-plugins.io
+    on_success: change
+    on_failure: always
+script:
+- gem build sensu-plugins-systemd.gemspec
+- gem install sensu-plugins-systemd-*.gem
+- bundle exec rake default
+deploy:
+  provider: rubygems
+  api_key:
+    secure: Hf1ZRHiWtWvOlcoLmcFJSql688r7s8CkTRUO5FYvUBjJE/x/P2+UDFONcYzycEAkLXzv9MIMXHO8vZ2m5rVSqbiP055+MtzRnukO2OaF2Ke0vYCuArOxj/LvhKAuLJRVNYbD138MltCnqUMjU2Ks4b4Z/wtHqSkbOoBsyTwwpYq0HiCbQyGNkacGzMZ44vnPR3cS0TrljjwYhnn1gDKkEkQf1p3iNrmIIapspU64U36KsxaGccFiXo2YSI9vBY+kssfGIOB5YAXoFHQ3YqdTpGMy7Q587IttlIlPQwhvYvK9lCZMZSCxmaZMGq2zy+3ttKe9CEejPGAtaPkiYrmmuM1hZUgQDk94znsTitpZxX5vlFMv5BUnxiOHcL+aQKFG4DlTj7KD+7a0BPb3AbUeD2njql6elCXiGeqzKgjS5x9W7WDZdoMj8VdQWzs+hh98C9yY5DDipp13yGJ3gqzKmKRbaHXUA9wLY4ic0022+ZwxCKX5TKqjOAi8WmQSCG19r+/uIaFY5MeTE7wrsuA0oSWM5YA9UaJNf5WbpUpC9tLG2owvAOjtEwhBBS9EijhiME8ABKBqp/RWJYqrj8PDrucDYLm2pB2PzlLKqs/+UQ//Rh4U/TKRLdWBrCevVr5hw6TLRl5ThoEjL1heqHsoH3X51rhtt3MBleYkawn37jg=
+  gem: sensu-plugins-systemd
+  on:
+    tags: true
+    all_branches: true
+    rvm: 2.0
+    rvm: 2.1
+    rvm: 2.2
+    rvm: 2.3.0
+    rvm: 2.4.1
+    repo: sensu-plugins/sensu-plugins-systemd

CHANGELOG.md

@@ -1,8 +1,34 @@
-#Change Log
-This project adheres to [Semantic Versioning](http://semver.org/).
+# Change Log
+This CHANGELOG follows the format listed at [Our CHANGELOG Guidelines ](https://github.com/sensu-plugins/community/blob/master/HOW_WE_CHANGELOG.md).
+Which is based on [Keep A Changelog](http://keepachangelog.com/)
 
 This CHANGELOG follows the format listed at [Keep A Changelog](http://keepachangelog.com/)
 
+## [Unreleased]
+### Added
+- missing changelog entries (@majormoses)
+- standard PR templates (@majormoses)
+
+### Changed
+- update the location of our changelog format (@majormoses)
+- updated with standard `.travis.yml` and updated secret for deploy to rubygems (@majormoses)
+- updated with standard `.rubocop.yml` (@majormoses)
+- updated with standard `Rakefile` (@majormoses)
+
+
+## [0.0.5]
+### Changed
+- bumped version of gem
+
+## [0.0.4]
+### Fixed
+- check-systemd.rb: critical alert when requested service does not exist (@jgnagy)
+
+
 ## 0.0.1 - 2016-04-26
 ### Added
 - initial release
+
+[Unreleased]: https://github.com/sensu-plugins/sensu-plugins-systemd/compare/v0.0.5...HEAD
+[0.0.5]: https://github.com/sensu-plugins/sensu-plugins-systemd/compare/v0.0.4...v0.0.5
+[0.0.4]: https://github.com/sensu-plugins/sensu-plugins-systemd/compare/v0.0.3...v0.0.4

README.md

@@ -1,7 +1,7 @@
 ## Sensu-Plugins-systemd
-[![Build Status](https://travis-ci.org/mickfeech/sensu-plugins-systemd.svg?branch=master)](https://travis-ci.org/mickfeech/sensu-plugins-systemd)
-[![Gem Version](https://badge.fury.io/rb/sensu-plugins-systemd.svg)](http://badge.fury.io/rb/sensu-plugins-lvm-thinpools)
-[![Code Climate](https://codeclimate.com/github/mickfeech/sensu-plugins-systemd/badges/gpa.svg)](https://codeclimate.com/github/mickfeech/sensu-plugins-systemd)
+[![Build Status](https://travis-ci.org/sensu-plugins/sensu-plugins-systemd.svg?branch=master)](https://travis-ci.org/sensu-plugins/sensu-plugins-systemd)
+[![Gem Version](https://badge.fury.io/rb/sensu-plugins-systemd.svg)](http://badge.fury.io/rb/sensu-plugins-systemd)
+[![Code Climate](https://codeclimate.com/github/sensu-plugins/sensu-plugins-systemd/badges/gpa.svg)](https://codeclimate.com/github/sensu-plugins/sensu-plugins-systemd)
 ## Functionality
 This provides functionality to check if services are running for systemd.
 
@@ -14,3 +14,9 @@ Pass services as a comma delimited -s option
 ```
 check-systemd.rb -s SERVICE1.service,SERVICE2.service
 ```
+
+## Installation
+
+[Installation and Setup](http://sensu-plugins.io/docs/installation_instructions.html)
+
+## Notes

Rakefile

@@ -6,15 +6,6 @@ require 'rubocop/rake_task'
 require 'yard'
 require 'yard/rake/yardoc_task'
 
-desc 'Don\'t run Rubocop for unsupported versions'
-begin
-  args = if RUBY_VERSION >= '2.0.0'
-           %i[spec make_bin_executable yard rubocop check_binstubs]
-         else
-           %i[spec make_bin_executable yard]
-         end
-end
-
 YARD::Rake::YardocTask.new do |t|
   OTHER_PATHS = %w[].freeze
   t.files = ['lib/**/*.rb', 'bin/**/*.rb', OTHER_PATHS]
@@ -34,14 +25,16 @@ end
 
 desc 'Test for binstubs'
 task :check_binstubs do
-  bin_list = Gem::Specification.load('sensu-plugins-systemd.gemspec').executables
-  bin_list.each do |b|
-    `which #{ b }`
-    unless $CHILD_STATUS.success?
-      puts "#{b} was not a binstub"
-      exit
+  unless Dir.glob('bin/**/*.rb').empty?
+    bin_list = Gem::Specification.load('sensu-plugins-systemd.gemspec').executables
+    bin_list.each do |b|
+      `which #{ b }`
+      unless $CHILD_STATUS.success?
+        puts "#{b} was not a binstub"
+        exit
+      end
     end
   end
 end
 
-task default: args
+task default: %i[spec make_bin_executable yard rubocop check_binstubs]

sensu-plugins-systemd.gemspec

@@ -9,21 +9,24 @@ else
   require_relative 'lib/sensu-plugins-systemd'
 end
 
-Gem::Specification.new do |s|
+Gem::Specification.new do |s| # rubocop:disable Metrics/BlockLength
   s.name          = 'sensu-plugins-systemd'
   s.version       = SensuPluginsSystemd::Version::VER_STRING
   s.platform      = Gem::Platform::RUBY
   s.authors       = ['mickfeech and contributors']
   s.date          = Date.today.to_s
-  s.email         = ['cmcfee@kent.edu']
+  s.email         = [
+    'cmcfee@kent.edu',
+    '<sensu-users@googlegroups.com>'
+  ]
   s.executables   = Dir.glob('bin/**/*.rb').map { |file| File.basename(file) }
   s.homepage      = 'https://github.com/mickfeech/sensu-plugins-systemd'
   s.summary       = 'This provides functionality to check systemd services.'
   s.description   = 'Plugins to provide functionality to check systemd services for Sensu, a monitoring framework'
   s.license       = 'MIT'
   s.has_rdoc      = false
   s.require_paths = ['lib']
-  s.files         = Dir['lib/**/*.rb']
+  s.files         = Dir.glob('{bin,lib}/**/*') + %w[LICENSE README.md CHANGELOG.md]
   # s.test_files    = Dir['test/*.rb']
   s.test_files    = s.files.grep(%r{^(test|spec|features)/})