Merge pull request #2 from jgnagy/bugfix/alert-on-missing-services

Complaining about missing services

Author: mickfeech

Rakefile

@@ -9,16 +9,16 @@ require 'yard/rake/yardoc_task'
 desc 'Don\'t run Rubocop for unsupported versions'
 begin
   args = if RUBY_VERSION >= '2.0.0'
-           [:spec, :make_bin_executable, :yard, :rubocop, :check_binstubs]
+           %i[spec make_bin_executable yard rubocop check_binstubs]
          else
-           [:spec, :make_bin_executable, :yard]
+           %i[spec make_bin_executable yard]
          end
 end
 
 YARD::Rake::YardocTask.new do |t|
-  OTHER_PATHS = %w().freeze
+  OTHER_PATHS = %w[].freeze
   t.files = ['lib/**/*.rb', 'bin/**/*.rb', OTHER_PATHS]
-  t.options = %w(--markup-provider=redcarpet --markup=markdown --main=README.md --files CHANGELOG.md)
+  t.options = %w[--markup-provider=redcarpet --markup=markdown --main=README.md --files CHANGELOG.md]
 end
 
 RuboCop::RakeTask.new

bin/check-systemd.rb

@@ -41,6 +41,13 @@ def initialize
     @crit_service = []
   end
 
+  def all_service_names
+    systemd_output = `systemctl --no-legend`
+    systemd_output.split("\n").collect do |line|
+      line.split(' ').first
+    end
+  end
+
   def unit_services
     systemd_output = `systemctl --failed --no-legend`
     service_array = []
@@ -59,6 +66,10 @@ def unit_services
   end
 
   def check_systemd
+    @services.reject { |service| validate_presence_of(service) }.each do |gone|
+      @crit_service << "#{gone} - Not Present"
+    end
+
     unit_services.each do |service|
       if service['active'] != 'active'
         @crit_service << "#{service['name']} - #{service['active']}"
@@ -72,6 +83,10 @@ def service_summary
     @crit_service.join(', ')
   end
 
+  def validate_presence_of(service)
+    all_service_names.include?(service)
+  end
+
   def run
     check_systemd
     critical service_summary unless @crit_service.empty?