Bump phpstan and psalm

Author: VincentLanglet

composer.json

@@ -53,14 +53,14 @@
         "matthiasnoback/symfony-dependency-injection-test": "^4.0 || ^5.0",
         "phpstan/extension-installer": "^1.0",
         "phpstan/phpdoc-parser": "^1.0",
-        "phpstan/phpstan": "^1.0",
-        "phpstan/phpstan-phpunit": "^1.0",
-        "phpstan/phpstan-strict-rules": "^1.0",
-        "phpstan/phpstan-symfony": "^1.0",
+        "phpstan/phpstan": "^1.0 || ^2.0",
+        "phpstan/phpstan-phpunit": "^1.0 || ^2.0",
+        "phpstan/phpstan-strict-rules": "^1.0 || ^2.0",
+        "phpstan/phpstan-symfony": "^1.0 || ^2.0",
         "phpunit/phpunit": "^9.5",
-        "psalm/plugin-phpunit": "^0.18",
+        "psalm/plugin-phpunit": "^0.18 || ^0.19",
         "psalm/plugin-symfony": "^5.0",
-        "rector/rector": "^1.1",
+        "rector/rector": "^1.1 || ^2.0",
         "sonata-project/admin-bundle": "^4.34",
         "sonata-project/block-bundle": "^4.11 || ^5.0",
         "sonata-project/doctrine-orm-admin-bundle": "^4.0",
@@ -72,7 +72,7 @@
         "symfony/security-csrf": "^6.4 || ^7.1",
         "symfony/twig-bundle": "^6.4 || ^7.1",
         "symfony/yaml": "^6.4 || ^7.1",
-        "vimeo/psalm": "^5.0"
+        "vimeo/psalm": "^5.0 || ^6.10"
     },
     "conflict": {
         "doctrine/mongodb-odm": "<2.4",

phpstan-baseline.neon

@@ -11,3 +11,6 @@ parameters:
             message: "#^Parameter \\#2 \\$category of method Sonata\\\\ClassificationBundle\\\\Form\\\\Type\\\\CategorySelectorType\\:\\:childWalker\\(\\) expects Sonata\\\\ClassificationBundle\\\\Model\\\\CategoryInterface, Sonata\\\\ClassificationBundle\\\\Model\\\\CategoryInterface\\|Sonata\\\\ClassificationBundle\\\\Model\\\\ContextInterface given\\.$#"
             count: 1
             path: src/Form/Type/CategorySelectorType.php
+        -
+            message: '#^Call to method get\(\) of internal class Symfony\\Bundle\\FrameworkBundle\\Test\\TestContainer from outside its root namespace Symfony.$#'
+            path: tests/

psalm.xml

@@ -12,11 +12,7 @@
         <pluginClass class="Psalm\PhpUnitPlugin\Plugin"/>
     </plugins>
     <issueHandlers>
-        <InternalMethod>
-            <errorLevel type="suppress">
-                <directory name="tests/Controller"/>
-            </errorLevel>
-        </InternalMethod>
         <MissingClassConstType errorLevel="suppress"/>
+        <MissingOverrideAttribute errorLevel="suppress"/>
     </issueHandlers>
 </psalm>

src/DependencyInjection/SonataClassificationExtension.php

@@ -136,9 +136,12 @@ private function registerSonataDoctrineMapping(array $config): void
         );
 
         $categoryCascade = ['persist', 'refresh', 'merge', 'detach'];
-        $categoryIsEntity = \in_array(BaseCategory::class, class_parents($config['class']['category']), true);
-        if ($categoryIsEntity && class_exists(EntityManager::class) && !method_exists(EntityManager::class, 'merge')) { // @phpstan-ignore-line
-            unset($categoryCascade[array_search('merge', $categoryCascade, true)]);
+        $parents = class_parents($config['class']['category']);
+        if (false !== $parents) {
+            $categoryIsEntity = \in_array(BaseCategory::class, class_parents($config['class']['category']), true);
+            if ($categoryIsEntity && class_exists(EntityManager::class) && !method_exists(EntityManager::class, 'merge')) { // @phpstan-ignore-line
+                unset($categoryCascade[array_search('merge', $categoryCascade, true)]);
+            }
         }
         $collector->addAssociation(
             $config['class']['category'],

tests/App/Entity/Category.php

@@ -17,6 +17,9 @@
 use Doctrine\ORM\Mapping as ORM;
 use Sonata\ClassificationBundle\Entity\BaseCategory;
 
+/**
+ * @psalm-suppress ClassMustBeFinal
+ */
 #[ORM\Entity]
 #[ORM\Table(name: 'classification__category')]
 class Category extends BaseCategory

tests/App/Entity/Collection.php

@@ -17,6 +17,9 @@
 use Doctrine\ORM\Mapping as ORM;
 use Sonata\ClassificationBundle\Entity\BaseCollection;
 
+/**
+ * @psalm-suppress ClassMustBeFinal
+ */
 #[ORM\Entity]
 #[ORM\Table(name: 'classification__collection')]
 class Collection extends BaseCollection

tests/App/Entity/Context.php

@@ -17,6 +17,9 @@
 use Doctrine\ORM\Mapping as ORM;
 use Sonata\ClassificationBundle\Entity\BaseContext;
 
+/**
+ * @psalm-suppress ClassMustBeFinal
+ */
 #[ORM\Entity]
 #[ORM\Table(name: 'classification__context')]
 class Context extends BaseContext

tests/App/Entity/Tag.php

@@ -17,6 +17,9 @@
 use Doctrine\ORM\Mapping as ORM;
 use Sonata\ClassificationBundle\Entity\BaseTag;
 
+/**
+ * @psalm-suppress ClassMustBeFinal
+ */
 #[ORM\Entity]
 #[ORM\Table(name: 'classification__tag')]
 class Tag extends BaseTag

tests/Entity/CategoryManagerTest.php

@@ -20,7 +20,7 @@
 use Sonata\ClassificationBundle\Tests\App\Entity\Context;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 
-class CategoryManagerTest extends KernelTestCase
+final class CategoryManagerTest extends KernelTestCase
 {
     public function testGetRootCategoryWithChildren(): void
     {