Skip to content

Commit eab35f2

Browse files
committed
[ModelicaSystemDoE] fix unittest
* test_ModelicaSystemDoE_local is tested * test_ModelicaSystemDoE_docker should work * test_ModelicaSystemDoE_WSL is untested
1 parent e3f180f commit eab35f2

1 file changed

Lines changed: 30 additions & 12 deletions

File tree

tests/test_ModelicaSystemDoE.py

Lines changed: 30 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,17 @@ def test_ModelicaSystemDoE_local(tmp_path, model_doe, param_doe):
5555
tmpdir = tmp_path / 'DoE'
5656
tmpdir.mkdir(exist_ok=True)
5757

58-
doe_mod = OMPython.ModelicaSystemDoE(
58+
mod = OMPython.ModelicaSystem()
59+
mod.model(
5960
model_file=model_doe,
6061
model_name="M",
62+
)
63+
64+
doe_mod = OMPython.ModelicaSystemDoE(
65+
mod=mod,
6166
parameters=param_doe,
6267
resultpath=tmpdir,
63-
simargs={"override": {'stopTime': 1.0}},
68+
simargs={"override": {'stopTime': '1.0'}},
6469
)
6570

6671
_run_ModelicaSystemDoe(doe_mod=doe_mod)
@@ -69,16 +74,22 @@ def test_ModelicaSystemDoE_local(tmp_path, model_doe, param_doe):
6974
@skip_on_windows
7075
@skip_python_older_312
7176
def test_ModelicaSystemDoE_docker(tmp_path, model_doe, param_doe):
72-
omcp = OMPython.OMCSessionDocker(docker="openmodelica/openmodelica:v1.25.0-minimal")
73-
omc = OMPython.OMCSessionZMQ(omc_process=omcp)
77+
omcs = OMPython.OMCSessionDocker(docker="openmodelica/openmodelica:v1.25.0-minimal")
78+
omc = OMPython.OMCSessionZMQ(omc_process=omcs)
7479
assert omc.sendExpression("getVersion()") == "OpenModelica 1.25.0"
7580

76-
doe_mod = OMPython.ModelicaSystemDoE(
81+
mod = OMPython.ModelicaSystem(
82+
session=omcs,
83+
)
84+
mod.model(
7785
model_file=model_doe,
7886
model_name="M",
87+
)
88+
89+
doe_mod = OMPython.ModelicaSystemDoE(
90+
mod=mod,
7991
parameters=param_doe,
80-
session=omcp,
81-
simargs={"override": {'stopTime': 1.0}},
92+
simargs={"override": {'stopTime': '1.0'}},
8293
)
8394

8495
_run_ModelicaSystemDoe(doe_mod=doe_mod)
@@ -87,15 +98,22 @@ def test_ModelicaSystemDoE_docker(tmp_path, model_doe, param_doe):
8798
@pytest.mark.skip(reason="Not able to run WSL on github")
8899
@skip_python_older_312
89100
def test_ModelicaSystemDoE_WSL(tmp_path, model_doe, param_doe):
90-
tmpdir = tmp_path / 'DoE'
91-
tmpdir.mkdir(exist_ok=True)
101+
omcs = OMPython.OMCSessionWSL()
102+
omc = OMPython.OMCSessionZMQ(omc_process=omcs)
103+
assert omc.sendExpression("getVersion()") == "OpenModelica 1.25.0"
92104

93-
doe_mod = OMPython.ModelicaSystemDoE(
105+
mod = OMPython.ModelicaSystem(
106+
session=omcs,
107+
)
108+
mod.model(
94109
model_file=model_doe,
95110
model_name="M",
111+
)
112+
113+
doe_mod = OMPython.ModelicaSystemDoE(
114+
mod=mod,
96115
parameters=param_doe,
97-
resultpath=tmpdir,
98-
simargs={"override": {'stopTime': 1.0}},
116+
simargs={"override": {'stopTime': '1.0'}},
99117
)
100118

101119
_run_ModelicaSystemDoe(doe_mod=doe_mod)

0 commit comments

Comments
 (0)