Skip to content

Commit ba2061e

Browse files
committed
add explicit buildbase option to use temporary container for backend builds
1 parent b0ff02d commit ba2061e

1 file changed

Lines changed: 21 additions & 10 deletions

File tree

build.py

Lines changed: 21 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -688,17 +688,17 @@ def onnxruntime_cmake_args(images, library_paths):
688688
)
689689

690690
if target_platform() == "windows":
691-
if "base" in images:
691+
if "buildbase" in images:
692692
cargs.append(
693693
cmake_backend_arg(
694-
"onnxruntime", "TRITON_BUILD_CONTAINER", None, images["base"]
694+
"onnxruntime", "TRITON_BUILD_CONTAINER", None, images["buildbase"]
695695
)
696696
)
697697
else:
698-
if "base" in images:
698+
if "buildbase" in images:
699699
cargs.append(
700700
cmake_backend_arg(
701-
"onnxruntime", "TRITON_BUILD_CONTAINER", None, images["base"]
701+
"onnxruntime", "TRITON_BUILD_CONTAINER", None, images["buildbase"]
702702
)
703703
)
704704
else:
@@ -754,17 +754,17 @@ def openvino_cmake_args():
754754
)
755755
]
756756
if target_platform() == "windows":
757-
if "base" in images:
757+
if "buildbase" in images:
758758
cargs.append(
759759
cmake_backend_arg(
760-
"openvino", "TRITON_BUILD_CONTAINER", None, images["base"]
760+
"openvino", "TRITON_BUILD_CONTAINER", None, images["buildbase"]
761761
)
762762
)
763763
else:
764-
if "base" in images:
764+
if "buildbase" in images:
765765
cargs.append(
766766
cmake_backend_arg(
767-
"openvino", "TRITON_BUILD_CONTAINER", None, images["base"]
767+
"openvino", "TRITON_BUILD_CONTAINER", None, images["buildbase"]
768768
)
769769
)
770770
else:
@@ -801,9 +801,9 @@ def dali_cmake_args():
801801

802802
def fil_cmake_args(images):
803803
cargs = [cmake_backend_enable("fil", "TRITON_FIL_DOCKER_BUILD", True)]
804-
if "base" in images:
804+
if "buildbase" in images:
805805
cargs.append(
806-
cmake_backend_arg("fil", "TRITON_BUILD_CONTAINER", None, images["base"])
806+
cmake_backend_arg("fil", "TRITON_BUILD_CONTAINER", None, images["buildbase"])
807807
)
808808
else:
809809
cargs.append(
@@ -2592,6 +2592,12 @@ def enable_all():
25922592
required=False,
25932593
help='Use specified Docker image in build as <image-name>,<full-image-name>. <image-name> can be "base", "gpu-base", or "pytorch".',
25942594
)
2595+
parser.add_argument(
2596+
"--use-buildbase",
2597+
default=False,
2598+
action="store_true",
2599+
help='Use local temporary "buildbase" Docker image as "base" image to build backends',
2600+
)
25952601

25962602
parser.add_argument(
25972603
"--enable-all",
@@ -2946,6 +2952,11 @@ def enable_all():
29462952
)
29472953
log('image "{}": "{}"'.format(parts[0], parts[1]))
29482954
images[parts[0]] = parts[1]
2955+
if FLAGS.use_buildbase:
2956+
images["buildbase"] = "tritonserver_buildbase"
2957+
else:
2958+
if "base" in images:
2959+
images["buildbase"] = images["base"]
29492960

29502961
# Initialize map of library paths for each backend.
29512962
library_paths = {}

0 commit comments

Comments
 (0)