Commit bde71b6
committed
chore: bump rubocop to ~> 1.86 and rubocop-rspec to ~> 3.9
Bumps the linting toolchain:
- rubocop: 1.72.2 (pinned exact) -> ~> 1.86
- rubocop-rspec: ~> 3.6 -> ~> 3.9
Loosens rubocop to a pessimistic constraint so it can pick up patch and
minor bumps without another Gemfile change.
The newer rubocop / rubocop-rspec set surfaces ten new offences. Nine of
them are two cops misfiring on `spec/spec_helper.rb`, which is integration
infrastructure (boots Typesense via docker-compose) rather than an
example file:
- `RSpec/Output` flags the `puts`/`print` calls that report
docker-compose startup progress to the operator. They are not
assertions on stdout, so the cop's intent does not apply.
- `Naming/PredicateMethod` flags `ensure_typesense_running`, which
returns a boolean but has heavy side effects (boots a docker
container); renaming it to `ensure_typesense_running?` would be
misleading.
Both cops are excluded only for `spec/spec_helper.rb`. The tenth offence
was a real but trivial `Style/HashAsLastArrayItem` /
`Layout/SpaceInsideHashLiteralBraces` in `collection_spec.rb`, fixed by
autocorrect.
Verified: `bundle exec rubocop` reports 97 files, 0 offences. Full RSpec
suite is unchanged at 151 / 1 / 27 (the single pre-existing `truncate_len`
integration failure on master remains, unrelated).1 parent f33f224 commit bde71b6
3 files changed
Lines changed: 11 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
50 | 58 | | |
51 | 59 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
19 | | - | |
| 18 | + | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
| 55 | + | |
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
| |||
0 commit comments