Skip to content

Commit 2f5d0f1

Browse files
Joseph GordonBridgeAR
authored andcommitted
doc: improved flow for macOS firewall script
PR-URL: nodejs#18689 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent cb88439 commit 2f5d0f1

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

BUILDING.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -107,18 +107,20 @@ On macOS, you will need to install the `Xcode Command Line Tools` by running
107107
installed, you can find them under the menu `Xcode -> Open Developer Tool ->
108108
More Developer Tools...`. This step will install `clang`, `clang++`, and
109109
`make`.
110-
* After building, you may want to setup [firewall rules](tools/macosx-firewall.sh)
111-
to avoid popups asking to accept incoming network connections when running
112-
tests:
113110

114111
If the path to your build directory contains a space, the build will likely
115112
fail.
116113

114+
After building, setting up [firewall rules](tools/macosx-firewall.sh) can avoid
115+
popups asking to accept incoming network connections when running tests.
116+
117+
Running the following script on macOS will add the firewall rules for the
118+
executable `node` in the `out` directory and the symbolic `node` link in the
119+
project's root directory.
120+
117121
```console
118122
$ sudo ./tools/macosx-firewall.sh
119123
```
120-
Running this script will add rules for the executable `node` in the `out`
121-
directory and the symbolic `node` link in the project's root directory.
122124

123125
On FreeBSD and OpenBSD, you may also need:
124126
* libexecinfo

0 commit comments

Comments
 (0)