Run Jest in production mode (facebook#11616)

* Move Jest setup files to /dev/ subdirectory

* Clone Jest /dev/ files into /prod/

* Move shared code into scripts/jest

* Move Jest config into the scripts folder

* Fix the equivalence test

It fails because the config is now passed to Jest explicitly.
But the test doesn't know about the config.

To fix this, we just run it via `yarn test` (which includes the config).
We already depend on Yarn for development anyway.

* Add yarn test-prod to run Jest with production environment

* Actually flip the production tests to run in prod environment

This produces a bunch of errors:

Test Suites: 64 failed, 58 passed, 122 total
Tests:       740 failed, 26 skipped, 1809 passed, 2575 total
Snapshots:   16 failed, 4 passed, 20 total

* Ignore expectDev() calls in production

Down from 740 to 175 failed.

Test Suites: 44 failed, 78 passed, 122 total
Tests:       175 failed, 26 skipped, 2374 passed, 2575 total
Snapshots:   16 failed, 4 passed, 20 total

* Decode errors so tests can assert on their messages

Down from 175 to 129.

Test Suites: 33 failed, 89 passed, 122 total
Tests:       129 failed, 1029 skipped, 1417 passed, 2575 total
Snapshots:   16 failed, 4 passed, 20 total

* Remove ReactDOMProduction-test

There is no need for it now. The only test that was special is moved into ReactDOM-test.

* Remove production switches from ReactErrorUtils

The tests now run in production in a separate pass.

* Add and use spyOnDev() for warnings

This ensures that by default we expect no warnings in production bundles.
If the warning *is* expected, use the regular spyOn() method.

This currently breaks all expectDev() assertions without __DEV__ blocks so we go back to:

Test Suites: 56 failed, 65 passed, 121 total
Tests:       379 failed, 1029 skipped, 1148 passed, 2556 total
Snapshots:   16 failed, 4 passed, 20 total

* Replace expectDev() with expect() in __DEV__ blocks

We started using spyOnDev() for console warnings to ensure we don't *expect* them to occur in production. As a consequence, expectDev() assertions on console.error.calls fail because console.error.calls doesn't exist. This is actually good because it would help catch accidental warnings in production.

To solve this, we are getting rid of expectDev() altogether, and instead introduce explicit expectation branches. We'd need them anyway for testing intentional behavior differences.

This commit replaces all expectDev() calls with expect() calls in __DEV__ blocks. It also removes a few unnecessary expect() checks that no warnings were produced (by also removing the corresponding spyOnDev() calls).

Some DEV-only assertions used plain expect(). Those were also moved into __DEV__ blocks.

ReactFiberErrorLogger was special because it console.error()'s in production too. So in that case I intentionally used spyOn() instead of spyOnDev(), and added extra assertions.

This gets us down to:

Test Suites: 21 failed, 100 passed, 121 total
Tests:       72 failed, 26 skipped, 2458 passed, 2556 total
Snapshots:   16 failed, 4 passed, 20 total

* Enable User Timing API for production testing

We could've disabled it, but seems like a good idea to test since we use it at FB.

* Test for explicit Object.freeze() differences between PROD and DEV

This is one of the few places where DEV and PROD behavior differs for performance reasons.
Now we explicitly test both branches.

* Run Jest via "yarn test" on CI

* Remove unused variable

* Assert different error messages

* Fix error handling tests

This logic is really complicated because of the global ReactFiberErrorLogger mock.
I understand it now, so I added TODOs for later.

It can be much simpler if we change the rest of the tests that assert uncaught errors to also assert they are logged as warnings.
Which mirrors what happens in practice anyway.

* Fix more assertions

* Change tests to document the DEV/PROD difference for state invariant

It is very likely unintentional but I don't want to change behavior in this PR.
Filed a follow up as facebook#11618.

* Remove unnecessary split between DEV/PROD ref tests

* Fix more test message assertions

* Make validateDOMNesting tests DEV-only

* Fix error message assertions

* Document existing DEV/PROD message difference (possible bug)

* Change mocking assertions to be DEV-only

* Fix the error code test

* Fix more error message assertions

* Fix the last failing test due to known issue

* Run production tests on CI

* Unify configuration

* Fix coverage script

* Remove expectDev from eslintrc

* Run everything in band

We used to before, too. I just forgot to add the arguments after deleting the script.

Author: gaearon

.eslintrc.js

@@ -59,6 +59,6 @@ module.exports = {
   },
 
   globals: {
-    expectDev: true,
+    spyOnDev: true,
   },
 };

package.json

@@ -45,6 +45,7 @@
     "core-js": "^2.2.1",
     "coveralls": "^2.11.6",
     "create-react-class": "^15.6.2",
+    "cross-env": "^5.1.1",
     "del": "^2.0.2",
     "derequire": "^2.0.3",
     "escape-string-regexp": "^1.0.5",
@@ -102,7 +103,8 @@
     "linc": "node ./scripts/tasks/linc.js",
     "lint": "node ./scripts/tasks/eslint.js",
     "postinstall": "node node_modules/fbjs-scripts/node/check-dev-engines.js package.json",
-    "test": "jest",
+    "test": "cross-env NODE_ENV=development jest",
+    "test-prod": "cross-env NODE_ENV=production jest",
     "flow": "node ./scripts/tasks/flow.js",
     "prettier": "node ./scripts/prettier/index.js write-changed",
     "prettier-all": "node ./scripts/prettier/index.js write",

packages/react-dom/src/__tests__/CSSPropertyOperations-test.js

@@ -91,15 +91,17 @@ describe('CSSPropertyOperations', () => {
       }
     }
 
-    spyOn(console, 'error');
+    spyOnDev(console, 'error');
     var root = document.createElement('div');
     ReactDOM.render(<Comp />, root);
-    expectDev(console.error.calls.count()).toBe(1);
-    expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toEqual(
-      'Warning: Unsupported style property background-color. Did you mean backgroundColor?' +
-        '\n    in div (at **)' +
-        '\n    in Comp (at **)',
-    );
+    if (__DEV__) {
+      expect(console.error.calls.count()).toBe(1);
+      expect(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toEqual(
+        'Warning: Unsupported style property background-color. Did you mean backgroundColor?' +
+          '\n    in div (at **)' +
+          '\n    in Comp (at **)',
+      );
+    }
   });
 
   it('should warn when updating hyphenated style names', () => {
@@ -111,7 +113,7 @@ describe('CSSPropertyOperations', () => {
       }
     }
 
-    spyOn(console, 'error');
+    spyOnDev(console, 'error');
     var styles = {
       '-ms-transform': 'translate3d(0, 0, 0)',
       '-webkit-transform': 'translate3d(0, 0, 0)',
@@ -120,17 +122,19 @@ describe('CSSPropertyOperations', () => {
     ReactDOM.render(<Comp />, root);
     ReactDOM.render(<Comp style={styles} />, root);
 
-    expectDev(console.error.calls.count()).toBe(2);
-    expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toEqual(
-      'Warning: Unsupported style property -ms-transform. Did you mean msTransform?' +
-        '\n    in div (at **)' +
-        '\n    in Comp (at **)',
-    );
-    expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(1)[0])).toEqual(
-      'Warning: Unsupported style property -webkit-transform. Did you mean WebkitTransform?' +
-        '\n    in div (at **)' +
-        '\n    in Comp (at **)',
-    );
+    if (__DEV__) {
+      expect(console.error.calls.count()).toBe(2);
+      expect(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toEqual(
+        'Warning: Unsupported style property -ms-transform. Did you mean msTransform?' +
+          '\n    in div (at **)' +
+          '\n    in Comp (at **)',
+      );
+      expect(normalizeCodeLocInfo(console.error.calls.argsFor(1)[0])).toEqual(
+        'Warning: Unsupported style property -webkit-transform. Did you mean WebkitTransform?' +
+          '\n    in div (at **)' +
+          '\n    in Comp (at **)',
+      );
+    }
   });
 
   it('warns when miscapitalizing vendored style names', () => {
@@ -150,23 +154,25 @@ describe('CSSPropertyOperations', () => {
       }
     }
 
-    spyOn(console, 'error');
+    spyOnDev(console, 'error');
     var root = document.createElement('div');
     ReactDOM.render(<Comp />, root);
-    // msTransform is correct already and shouldn't warn
-    expectDev(console.error.calls.count()).toBe(2);
-    expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toEqual(
-      'Warning: Unsupported vendor-prefixed style property oTransform. ' +
-        'Did you mean OTransform?' +
-        '\n    in div (at **)' +
-        '\n    in Comp (at **)',
-    );
-    expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(1)[0])).toEqual(
-      'Warning: Unsupported vendor-prefixed style property webkitTransform. ' +
-        'Did you mean WebkitTransform?' +
-        '\n    in div (at **)' +
-        '\n    in Comp (at **)',
-    );
+    if (__DEV__) {
+      // msTransform is correct already and shouldn't warn
+      expect(console.error.calls.count()).toBe(2);
+      expect(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toEqual(
+        'Warning: Unsupported vendor-prefixed style property oTransform. ' +
+          'Did you mean OTransform?' +
+          '\n    in div (at **)' +
+          '\n    in Comp (at **)',
+      );
+      expect(normalizeCodeLocInfo(console.error.calls.argsFor(1)[0])).toEqual(
+        'Warning: Unsupported vendor-prefixed style property webkitTransform. ' +
+          'Did you mean WebkitTransform?' +
+          '\n    in div (at **)' +
+          '\n    in Comp (at **)',
+      );
+    }
   });
 
   it('should warn about style having a trailing semicolon', () => {
@@ -187,22 +193,24 @@ describe('CSSPropertyOperations', () => {
       }
     }
 
-    spyOn(console, 'error');
+    spyOnDev(console, 'error');
     var root = document.createElement('div');
     ReactDOM.render(<Comp />, root);
-    expectDev(console.error.calls.count()).toBe(2);
-    expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toEqual(
-      "Warning: Style property values shouldn't contain a semicolon. " +
-        'Try "backgroundColor: blue" instead.' +
-        '\n    in div (at **)' +
-        '\n    in Comp (at **)',
-    );
-    expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(1)[0])).toEqual(
-      "Warning: Style property values shouldn't contain a semicolon. " +
-        'Try "color: red" instead.' +
-        '\n    in div (at **)' +
-        '\n    in Comp (at **)',
-    );
+    if (__DEV__) {
+      expect(console.error.calls.count()).toBe(2);
+      expect(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toEqual(
+        "Warning: Style property values shouldn't contain a semicolon. " +
+          'Try "backgroundColor: blue" instead.' +
+          '\n    in div (at **)' +
+          '\n    in Comp (at **)',
+      );
+      expect(normalizeCodeLocInfo(console.error.calls.argsFor(1)[0])).toEqual(
+        "Warning: Style property values shouldn't contain a semicolon. " +
+          'Try "color: red" instead.' +
+          '\n    in div (at **)' +
+          '\n    in Comp (at **)',
+      );
+    }
   });
 
   it('should warn about style containing a NaN value', () => {
@@ -214,16 +222,18 @@ describe('CSSPropertyOperations', () => {
       }
     }
 
-    spyOn(console, 'error');
+    spyOnDev(console, 'error');
     var root = document.createElement('div');
     ReactDOM.render(<Comp />, root);
 
-    expectDev(console.error.calls.count()).toBe(1);
-    expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toEqual(
-      'Warning: `NaN` is an invalid value for the `fontSize` css style property.' +
-        '\n    in div (at **)' +
-        '\n    in Comp (at **)',
-    );
+    if (__DEV__) {
+      expect(console.error.calls.count()).toBe(1);
+      expect(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toEqual(
+        'Warning: `NaN` is an invalid value for the `fontSize` css style property.' +
+          '\n    in div (at **)' +
+          '\n    in Comp (at **)',
+      );
+    }
   });
 
   it('should not warn when setting CSS custom properties', () => {
@@ -246,16 +256,18 @@ describe('CSSPropertyOperations', () => {
       }
     }
 
-    spyOn(console, 'error');
+    spyOnDev(console, 'error');
     var root = document.createElement('div');
     ReactDOM.render(<Comp />, root);
 
-    expectDev(console.error.calls.count()).toBe(1);
-    expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toEqual(
-      'Warning: `Infinity` is an invalid value for the `fontSize` css style property.' +
-        '\n    in div (at **)' +
-        '\n    in Comp (at **)',
-    );
+    if (__DEV__) {
+      expect(console.error.calls.count()).toBe(1);
+      expect(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toEqual(
+        'Warning: `Infinity` is an invalid value for the `fontSize` css style property.' +
+          '\n    in div (at **)' +
+          '\n    in Comp (at **)',
+      );
+    }
   });
 
   it('should not add units to CSS custom properties', () => {

packages/react-dom/src/__tests__/DOMPropertyOperations-test.js

@@ -151,7 +151,7 @@ describe('DOMPropertyOperations', () => {
 
     it('should not remove attributes for special properties', () => {
       var container = document.createElement('div');
-      spyOn(console, 'error');
+      spyOnDev(console, 'error');
       ReactDOM.render(
         <input type="text" value="foo" onChange={function() {}} />,
         container,
@@ -164,10 +164,12 @@ describe('DOMPropertyOperations', () => {
       );
       expect(container.firstChild.getAttribute('value')).toBe('foo');
       expect(container.firstChild.value).toBe('foo');
-      expect(console.error.calls.count()).toBe(1);
-      expect(console.error.calls.argsFor(0)[0]).toContain(
-        'A component is changing a controlled input of type text to be uncontrolled',
-      );
+      if (__DEV__) {
+        expect(console.error.calls.count()).toBe(1);
+        expect(console.error.calls.argsFor(0)[0]).toContain(
+          'A component is changing a controlled input of type text to be uncontrolled',
+        );
+      }
     });
   });
 });

packages/react-dom/src/__tests__/EventPluginHub-test.js

@@ -22,7 +22,7 @@ describe('EventPluginHub', () => {
   });
 
   it('should prevent non-function listeners, at dispatch', () => {
-    spyOn(console, 'error');
+    spyOnDev(console, 'error');
     var node = ReactTestUtils.renderIntoDocument(
       <div onClick="not a function" />,
     );
@@ -31,10 +31,12 @@ describe('EventPluginHub', () => {
     }).toThrowError(
       'Expected `onClick` listener to be a function, instead got a value of `string` type.',
     );
-    expectDev(console.error.calls.count()).toBe(1);
-    expectDev(console.error.calls.argsFor(0)[0]).toContain(
-      'Expected `onClick` listener to be a function, instead got a value of `string` type.',
-    );
+    if (__DEV__) {
+      expect(console.error.calls.count()).toBe(1);
+      expect(console.error.calls.argsFor(0)[0]).toContain(
+        'Expected `onClick` listener to be a function, instead got a value of `string` type.',
+      );
+    }
   });
 
   it('should not prevent null listeners, at dispatch', () => {

packages/react-dom/src/__tests__/ReactBrowserEventEmitter-test.js

@@ -285,13 +285,15 @@ describe('ReactBrowserEventEmitter', () => {
     putListener(CHILD, ON_CLICK_KEY, recordIDAndReturnFalse.bind(null, CHILD));
     putListener(PARENT, ON_CLICK_KEY, recordID.bind(null, PARENT));
     putListener(GRANDPARENT, ON_CLICK_KEY, recordID.bind(null, GRANDPARENT));
-    spyOn(console, 'error');
+    spyOnDev(console, 'error');
     ReactTestUtils.Simulate.click(CHILD);
     expect(idCallOrder.length).toBe(3);
     expect(idCallOrder[0]).toBe(CHILD);
     expect(idCallOrder[1]).toBe(PARENT);
     expect(idCallOrder[2]).toBe(GRANDPARENT);
-    expectDev(console.error.calls.count()).toEqual(0);
+    if (__DEV__) {
+      expect(console.error.calls.count()).toEqual(0);
+    }
   });
 
   /**