Adjust signature for koinInject and propose koinInject with ParametersHolder direct as API to avoid having to unwrap parameters

Author: arnaudgiuliani

projects/compose/koin-compose/src/commonMain/kotlin/org/koin/compose/Inject.kt

@@ -23,24 +23,72 @@ import org.koin.core.parameter.ParametersHolder
 import org.koin.core.qualifier.Qualifier
 import org.koin.core.scope.Scope
 
+
 /**
- * Resolve Koin dependency
+ * Resolve Koin dependency for given Type T
+ *
+ * <u>Note</u> this version unwrap parameters to ParametersHolder in order to let remember all parameters
+ * This parameters unwrap will be triggered on recomposition
  *
- * @param qualifier
- * @param scope - Koin's root default
- * @param parameters - injected parameters
+ * For better performances we advise to use koinInject(Qualifier,Scope,ParametersHolder)
+ *
+ * @param qualifier - dependency qualifier
+ * @param scope - Koin's root by default
+ * @param parameters - injected parameters (with lambda & parametersOf())
+ * @return instance of type T
  *
  * @author Arnaud Giuliani
  */
+@Composable
 @OptIn(KoinInternalApi::class)
+inline fun <reified T> koinInject(
+    qualifier: Qualifier? = null,
+    scope: Scope = currentKoinScope(),
+    noinline parameters: ParametersDefinition,
+): T {
+    val p = parameters.invoke()
+    return remember(qualifier, scope, p) {
+        scope.getWithParameters(T::class, qualifier, p)
+    }
+}
+
+/**
+ * Resolve Koin dependency for given Type T
+ *
+ * @param qualifier - dependency qualifier
+ * @param scope - Koin's root by default
+ * @param parameters - parameters (used with parametersOf(), no lambda)
+ * @return instance of type T
+ *
+ * @author Arnaud Giuliani
+ */
 @Composable
+@OptIn(KoinInternalApi::class)
 inline fun <reified T> koinInject(
     qualifier: Qualifier? = null,
     scope: Scope = currentKoinScope(),
-    noinline parameters: ParametersDefinition? = null,
+    parameters: ParametersHolder,
+): T {
+    return remember(qualifier, scope, parameters) {
+        scope.getWithParameters(T::class, qualifier, parameters)
+    }
+}
+
+/**
+ * Resolve Koin dependency for given Type T
+ *
+ * @param qualifier - dependency qualifier
+ * @param scope - Koin's root by default
+ * @return instance of type T
+ *
+ * @author Arnaud Giuliani
+ */
+@Composable
+inline fun <reified T> koinInject(
+    qualifier: Qualifier? = null,
+    scope: Scope = currentKoinScope()
 ): T {
-    val params: ParametersHolder? = parameters?.invoke()
-    return remember(qualifier, scope, params) {
-        scope.getWithParameters(T::class, qualifier,params)
+    return remember(qualifier, scope) {
+        scope.get(T::class, qualifier)
     }
 }