fix: fixed citadelAllowParams for oauth audit flags

Author: lwin-kyaw

src/helpers/citadelUtils.ts

@@ -2,6 +2,7 @@ import { BUILD_ENV_TYPE, CITADEL_SERVER_MAP, TORUS_NETWORK_TYPE } from "@torusla
 import { get, put } from "@toruslabs/http-helpers";
 
 import { RetrieveSharesParams } from "../interfaces";
+import { isNullOrUndefined } from "./common";
 
 export interface CitadelAuthFlowAuditParams {
   oauthInitiated?: boolean;
@@ -41,19 +42,19 @@ export function buildAllowUrl(params: CitadelAllowParams): string {
   if (params.source) {
     url.searchParams.set("source", params.source);
   }
-  if (params.oauthInitiated) {
+  if (!isNullOrUndefined(params.oauthInitiated)) {
     url.searchParams.set("oauthinitiated", params.oauthInitiated.toString());
   }
-  if (params.oauthVerified) {
+  if (!isNullOrUndefined(params.oauthVerified)) {
     url.searchParams.set("oauthverified", params.oauthVerified.toString());
   }
-  if (params.oauthCompleted) {
+  if (!isNullOrUndefined(params.oauthCompleted)) {
     url.searchParams.set("oauthcompleted", params.oauthCompleted.toString());
   }
-  if (params.oauthVerificationFailed) {
+  if (!isNullOrUndefined(params.oauthVerificationFailed)) {
     url.searchParams.set("oauthverificationfailed", params.oauthVerificationFailed.toString());
   }
-  if (params.oauthFailed) {
+  if (!isNullOrUndefined(params.oauthFailed)) {
     url.searchParams.set("oauthfailed", params.oauthFailed.toString());
   }
   return url.toString();

src/helpers/common.ts

@@ -161,3 +161,7 @@ export function retryCommitment(executionPromise: () => Promise<JRPCResponse<Com
 
   return retryWithBackoff(0);
 }
+
+export function isNullOrUndefined(value: unknown): value is null | undefined {
+  return value === null || value === undefined;
+}