Skip to content

Commit fc1e5be

Browse files
FenikSRT4LocalIdentity
andauthored
Fix crash when hovering over more damage calc breakdown for Kinetic Fusillade of Destruction (#9752)
* [ISSUE-9735] KF of Desctruction Calc Error * Regenerates the skills because of a reference to KineticFusilladeOfDestruction instead of to KineticFusilladeAltX which is the proper key for the skill. This reference was causing errors for some of the hover tooltips in the calcs tab. * Fix PR Removed changes from exporting using the wrong game version Also fix issue with Charged Dash of Projection --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
1 parent 4488e67 commit fc1e5be

File tree

4 files changed

+18
-18
lines changed

4 files changed

+18
-18
lines changed

src/Data/Skills/act_dex.lua

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4037,10 +4037,10 @@ skills["ChargedDash"] = {
40374037
},
40384038
},
40394039
preDamageFunc = function(activeSkill, output)
4040-
if activeSkill.skillPart == 3 then
4041-
local finalWaveDamageModifier = activeSkill.skillModList:Sum("INC", activeSkill.skillCfg, "chargedDashFinalDamageModifier")
4042-
activeSkill.skillModList:NewMod("Damage", "MORE", finalWaveDamageModifier, "Skill:ChargedDash", ModFlag.Attack, { type = "Release Damage", skillPart = 3 })
4043-
end
4040+
if activeSkill.skillPart == 3 then
4041+
local finalWaveDamageModifier = activeSkill.skillModList:Sum("INC", activeSkill.skillCfg, "chargedDashFinalDamageModifier")
4042+
activeSkill.skillModList:NewMod("Damage", "MORE", finalWaveDamageModifier, "Skill:ChargedDash", ModFlag.Attack, { type = "Release Damage", skillPart = 3 })
4043+
end
40444044
end,
40454045
statMap = {
40464046
["base_skill_show_average_damage_instead_of_dps"] = {
@@ -4164,10 +4164,10 @@ skills["ChargedDashAltX"] = {
41644164
},
41654165
},
41664166
preDamageFunc = function(activeSkill, output)
4167-
if activeSkill.skillPart == 3 then
4168-
local finalWaveDamageModifier = activeSkill.skillModList:Sum("INC", activeSkill.skillCfg, "chargedDashFinalDamageModifier")
4169-
activeSkill.skillModList:NewMod("Damage", "MORE", finalWaveDamageModifier, "Skill:ChargedDashofProjection", ModFlag.Attack, { type = "Release Damage", skillPart = 3 })
4170-
end
4167+
if activeSkill.skillPart == 3 then
4168+
local finalWaveDamageModifier = activeSkill.skillModList:Sum("INC", activeSkill.skillCfg, "chargedDashFinalDamageModifier")
4169+
activeSkill.skillModList:NewMod("Damage", "MORE", finalWaveDamageModifier, "Skill:ChargedDashAltX", ModFlag.Attack, { type = "Release Damage", skillPart = 3 })
4170+
end
41714171
end,
41724172
statMap = {
41734173
["base_skill_show_average_damage_instead_of_dps"] = {

src/Data/Skills/act_int.lua

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11479,7 +11479,7 @@ skills["KineticFusilladeAltX"] = {
1147911479
-- Average multiplier: sum of (0, X, 2X, 3X, ..., (n-1)X) / n
1148011480
-- This equals: X * (0 + 1 + 2 + ... + (n-1)) / n = X * n(n-1)/2 / n = X * (n-1)/2
1148111481
local avgMoreMult = moreDamagePerProj * (output.ProjectileCount - 1) / 2
11482-
activeSkill.skillModList:NewMod("Damage", "MORE", avgMoreMult, "Skill:KineticFusilladeofDetonation", ModFlag.Hit)
11482+
activeSkill.skillModList:NewMod("Damage", "MORE", avgMoreMult, "Skill:KineticFusilladeAltX", ModFlag.Hit)
1148311483

1148411484
-- Store the average multiplier for display
1148511485
output.KineticFusilladeAvgMoreMult = avgMoreMult

src/Export/Skills/act_dex.txt

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -687,10 +687,10 @@ local skills, mod, flag, skill = ...
687687
},
688688
},
689689
preDamageFunc = function(activeSkill, output)
690-
if activeSkill.skillPart == 3 then
691-
local finalWaveDamageModifier = activeSkill.skillModList:Sum("INC", activeSkill.skillCfg, "chargedDashFinalDamageModifier")
692-
activeSkill.skillModList:NewMod("Damage", "MORE", finalWaveDamageModifier, "Skill:ChargedDash", ModFlag.Attack, { type = "Release Damage", skillPart = 3 })
693-
end
690+
if activeSkill.skillPart == 3 then
691+
local finalWaveDamageModifier = activeSkill.skillModList:Sum("INC", activeSkill.skillCfg, "chargedDashFinalDamageModifier")
692+
activeSkill.skillModList:NewMod("Damage", "MORE", finalWaveDamageModifier, "Skill:ChargedDash", ModFlag.Attack, { type = "Release Damage", skillPart = 3 })
693+
end
694694
end,
695695
statMap = {
696696
["base_skill_show_average_damage_instead_of_dps"] = {
@@ -729,10 +729,10 @@ local skills, mod, flag, skill = ...
729729
},
730730
},
731731
preDamageFunc = function(activeSkill, output)
732-
if activeSkill.skillPart == 3 then
733-
local finalWaveDamageModifier = activeSkill.skillModList:Sum("INC", activeSkill.skillCfg, "chargedDashFinalDamageModifier")
734-
activeSkill.skillModList:NewMod("Damage", "MORE", finalWaveDamageModifier, "Skill:ChargedDashofProjection", ModFlag.Attack, { type = "Release Damage", skillPart = 3 })
735-
end
732+
if activeSkill.skillPart == 3 then
733+
local finalWaveDamageModifier = activeSkill.skillModList:Sum("INC", activeSkill.skillCfg, "chargedDashFinalDamageModifier")
734+
activeSkill.skillModList:NewMod("Damage", "MORE", finalWaveDamageModifier, "Skill:ChargedDashAltX", ModFlag.Attack, { type = "Release Damage", skillPart = 3 })
735+
end
736736
end,
737737
statMap = {
738738
["base_skill_show_average_damage_instead_of_dps"] = {

src/Export/Skills/act_int.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2441,7 +2441,7 @@ local skills, mod, flag, skill = ...
24412441
-- Average multiplier: sum of (0, X, 2X, 3X, ..., (n-1)X) / n
24422442
-- This equals: X * (0 + 1 + 2 + ... + (n-1)) / n = X * n(n-1)/2 / n = X * (n-1)/2
24432443
local avgMoreMult = moreDamagePerProj * (output.ProjectileCount - 1) / 2
2444-
activeSkill.skillModList:NewMod("Damage", "MORE", avgMoreMult, "Skill:KineticFusilladeofDetonation", ModFlag.Hit)
2444+
activeSkill.skillModList:NewMod("Damage", "MORE", avgMoreMult, "Skill:KineticFusilladeAltX", ModFlag.Hit)
24452445

24462446
-- Store the average multiplier for display
24472447
output.KineticFusilladeAvgMoreMult = avgMoreMult

0 commit comments

Comments
 (0)