Merge pull request #1 from benjchristensen/api-and-naming

Refactoring conventions

Author: benjchristensen

rxjava-core/build.gradle

@@ -1,6 +1,10 @@
 apply plugin: 'java'
 apply plugin: 'eclipse'
 
+// we want to target Java 1.5 so this can be used on Android
+sourceCompatibility = JavaVersion.VERSION_1_5
+targetCompatibility = JavaVersion.VERSION_1_5
+
 dependencies {
     compile 'org.slf4j:slf4j-api:1.7.0'
     compile 'com.google.code.findbugs:jsr305:2.0.0'

rxjava-core/src/main/java/org/rx/functions/Func0.java

@@ -2,4 +2,4 @@
 
 public interface Func0<R> {
     public R call();
-} 
+}

rxjava-core/src/main/java/org/rx/functions/Func1.java

@@ -2,4 +2,4 @@
 
 public interface Func1<R, T1> {
     public R call(T1 t1);
-} 
+}

rxjava-core/src/main/java/org/rx/functions/Func2.java

@@ -2,4 +2,4 @@
 
 public interface Func2<R, T1, T2> {
     public R call(T1 t1, T2 t2);
-} 
+}

rxjava-core/src/main/java/org/rx/functions/Func3.java

@@ -2,4 +2,4 @@
 
 public interface Func3<R, T1, T2, T3> {
     public R call(T1 t1, T2 t2, T3 t3);
-} 
+}

rxjava-core/src/main/java/org/rx/functions/Func4.java

@@ -1,5 +1,5 @@
 package org.rx.functions;
 
 public interface Func4<R, T1, T2, T3, T4> {
-    public R call(T1 t1, T2 t2, T3 t3, T4 t4); 
+    public R call(T1 t1, T2 t2, T3 t3, T4 t4);
 }

…rations/AtomicWatchableSubscription.java …ations/AtomicObservableSubscription.javarxjava-core/src/main/java/org/rx/operations/AtomicWatchableSubscription.java renamed to rxjava-core/src/main/java/org/rx/operations/AtomicObservableSubscription.java rxjava-core/src/main/java/org/rx/operations/AtomicWatchableSubscription.java renamed to rxjava-core/src/main/java/org/rx/operations/AtomicObservableSubscription.java

@@ -5,23 +5,22 @@
 
 import javax.annotation.concurrent.ThreadSafe;
 
-import org.rx.reactive.IDisposable;
-
+import org.rx.reactive.Subscription;
 
 /**
- * Thread-safe wrapper around WatchableSubscription that ensures unsubscribe can be called only once.
+ * Thread-safe wrapper around ObservableSubscription that ensures unsubscribe can be called only once.
  */
 @ThreadSafe
-/* package */class AtomicWatchableSubscription implements IDisposable {
+/* package */final class AtomicObservableSubscription implements Subscription {
 
-    private AtomicReference<IDisposable> actualSubscription = new AtomicReference<IDisposable>();
+    private AtomicReference<Subscription> actualSubscription = new AtomicReference<Subscription>();
     private AtomicBoolean unsubscribed = new AtomicBoolean(false);
 
-    public AtomicWatchableSubscription() {
+    public AtomicObservableSubscription() {
 
     }
 
-    public AtomicWatchableSubscription(IDisposable actualSubscription) {
+    public AtomicObservableSubscription(Subscription actualSubscription) {
         this.actualSubscription.set(actualSubscription);
     }
 
@@ -32,7 +31,7 @@ public AtomicWatchableSubscription(IDisposable actualSubscription) {
      * @throws IllegalStateException
      *             if trying to set more than once (or use this method after setting via constructor)
      */
-    public AtomicWatchableSubscription setActual(IDisposable actualSubscription) {
+    public AtomicObservableSubscription setActual(Subscription actualSubscription) {
         if (!this.actualSubscription.compareAndSet(null, actualSubscription)) {
             throw new IllegalStateException("Can not set subscription more than once.");
         }
@@ -42,7 +41,7 @@ public AtomicWatchableSubscription setActual(IDisposable actualSubscription) {
     @Override
     public void unsubscribe() {
         // get the real thing and set to null in an atomic operation so we will only ever call unsubscribe once
-        IDisposable actual = actualSubscription.getAndSet(null);
+        Subscription actual = actualSubscription.getAndSet(null);
         // if it's not null we will unsubscribe
         if (actual != null) {
             actual.unsubscribe();

…ava/org/rx/operations/AtomicWatcher.java …va/org/rx/operations/AtomicObserver.javarxjava-core/src/main/java/org/rx/operations/AtomicWatcher.java renamed to rxjava-core/src/main/java/org/rx/operations/AtomicObserver.java rxjava-core/src/main/java/org/rx/operations/AtomicWatcher.java renamed to rxjava-core/src/main/java/org/rx/operations/AtomicObserver.java

@@ -2,13 +2,13 @@
 
 import javax.annotation.concurrent.ThreadSafe;
 
-import org.rx.reactive.IObserver;
+import org.rx.reactive.Observer;
 
 /**
- * A thread-safe Watcher for transitioning states in operators.
+ * A thread-safe Observer for transitioning states in operators.
  * <p>
  * Allows both single-threaded and multi-threaded execution controlled by the following FastProperty:
- * <li>reactive.watcher.multithreaded.enabled [Default: false]</li>
+ * <li>reactive.Observer.multithreaded.enabled [Default: false]</li>
  * <p>
  * Single-threaded Execution rules are:
  * <ul>
@@ -29,7 +29,7 @@
  * @param <T>
  */
 @ThreadSafe
-/* package */class AtomicWatcher<T> implements IObserver<T> {
+/* package */final class AtomicObserver<T> implements Observer<T> {
 
     /** Allow changing between forcing single or allowing multi-threaded execution of onNext */
     private static boolean allowMultiThreaded = true;
@@ -41,29 +41,29 @@
         }
     }
 
-    private final IObserver<T> watcher;
+    private final Observer<T> Observer;
 
-    public AtomicWatcher(IObserver<T> watcher, AtomicWatchableSubscription subscription) {
+    public AtomicObserver(Observer<T> Observer, AtomicObservableSubscription subscription) {
         if (allowMultiThreaded) {
-            this.watcher = new AtomicWatcherMultiThreaded<T>(watcher, subscription);
+            this.Observer = new AtomicObserverMultiThreaded<T>(Observer, subscription);
         } else {
-            this.watcher = new AtomicWatcherSingleThreaded<T>(watcher, subscription);
+            this.Observer = new AtomicObserverSingleThreaded<T>(Observer, subscription);
         }
     }
 
     @Override
     public void onCompleted() {
-        watcher.onCompleted();
+        Observer.onCompleted();
     }
 
     @Override
     public void onError(Exception e) {
-        watcher.onError(e);
+        Observer.onError(e);
     }
 
     @Override
     public void onNext(T args) {
-        watcher.onNext(args);
+        Observer.onNext(args);
     }
 
 }