fix: address review feedback - simplify style, drop emoji swap

Author: niklasmarderx

src/app/apps.rs

@@ -214,9 +214,8 @@ impl App {
         let name = self.search_name.clone();
         let theme_clone = theme.clone();
         let is_favourite = self.ranking == -1;
-        let heart = if is_favourite { "❤️" } else { "🤍" };
         row = row.push(
-            Button::new(Text::new(heart).width(Length::Fill).align_x(Alignment::End))
+            Button::new(Text::new("♥️").width(Length::Fill).align_x(Alignment::End))
                 .on_press_with(move || Message::ToggleFavouriteApp(name.clone()))
                 .width(Length::Fill)
                 .style(move |_, status| favourite_button_style(&theme_clone, status, is_favourite)),

src/styles.rs

@@ -80,18 +80,16 @@ pub fn favourite_button_style(
     status: button::Status,
     is_favourite: bool,
 ) -> button::Style {
-    let text_color = if is_favourite {
-        match status {
-            button::Status::Pressed => theme.text_color(0.8),
-            button::Status::Hovered => theme.text_color(0.9),
-            _ => theme.text_color(1.),
-        }
+    let (base, pressed, hovered) = if is_favourite {
+        (1.0, 0.8, 0.9)
     } else {
-        match status {
-            button::Status::Pressed => theme.text_color(1.),
-            button::Status::Hovered => theme.text_color(0.5),
-            _ => theme.text_color(0.1),
-        }
+        (0.1, 1.0, 0.5)
+    };
+
+    let text_color = match status {
+        button::Status::Pressed => theme.text_color(pressed),
+        button::Status::Hovered => theme.text_color(hovered),
+        _ => theme.text_color(base),
     };
 
     button::Style {