chore: Make test:types have no Nx output (#5500)

lachlancollins · web-flow · commit d76e474c572e · 2023-06-01T15:52:49.000+10:00
diff --git a/nx.json b/nx.json
@@ -51,26 +51,22 @@
   },
   "targetDefaults": {
     "test:lib": {
-      "outputs": ["{projectRoot}/coverage"],
+      "dependsOn": ["^build"],
       "inputs": ["default", "^public"],
-      "dependsOn": ["^build"]
+      "outputs": ["{projectRoot}/coverage"]
     },
     "test:eslint": {
-      "inputs": ["default", "^public"],
-      "dependsOn": ["^build"]
+      "dependsOn": ["^build"],
+      "inputs": ["default", "^public"]
     },
     "test:types": {
-      "outputs": [
-        "{projectRoot}/build/**/*.d.ts",
-        "{projectRoot}/build/.tsbuildinfo"
-      ],
-      "inputs": ["default", "^public"],
-      "dependsOn": ["^test:types"]
+      "dependsOn": ["^build"],
+      "inputs": ["default", "^public"]
     },
     "build": {
-      "outputs": ["{projectRoot}/build/**/*"],
+      "dependsOn": ["^build"],
       "inputs": ["default", "^public"],
-      "dependsOn": ["^build"]
+      "outputs": ["{projectRoot}/build/**/*"]
     },
     "test:build": {
       "dependsOn": ["build"],
diff --git a/packages/codemods/tsconfig.json b/packages/codemods/tsconfig.json
@@ -1,10 +1,8 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "composite": true,
     "outDir": "./build/lib",
-    "rootDir": "./src",
-    "tsBuildInfoFile": "./build/.tsbuildinfo"
+    "rootDir": "./src"
   },
   "include": ["src"]
 }
diff --git a/packages/eslint-plugin-query/package.json b/packages/eslint-plugin-query/package.json
@@ -22,7 +22,7 @@
     "clean": "rimraf ./build && rimraf ./coverage",
     "dev": "tsup --watch --sourcemap",
     "test:eslint": "eslint --ext .ts,.tsx ./src",
-    "test:types": "tsc --emitDeclarationOnly",
+    "test:types": "tsc --noEmit",
     "test:lib": "vitest run --coverage",
     "test:lib:dev": "pnpm run test:lib --watch",
     "build": "tsup --minify"
diff --git a/packages/eslint-plugin-query/tsconfig.json b/packages/eslint-plugin-query/tsconfig.json
@@ -1,10 +1,8 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "composite": true,
     "outDir": "./build/lib",
     "rootDir": "./src",
-    "tsBuildInfoFile": "./build/.tsbuildinfo",
     "types": ["vitest/globals"]
   },
   "include": ["src"]
diff --git a/packages/query-async-storage-persister/package.json b/packages/query-async-storage-persister/package.json
@@ -30,7 +30,7 @@
   "scripts": {
     "clean": "rimraf ./build && rimraf ./coverage",
     "test:eslint": "eslint --ext .ts,.tsx ./src",
-    "test:types": "pnpm build:types",
+    "test:types": "tsc --noEmit",
     "test:lib": "vitest run --coverage",
     "test:lib:dev": "pnpm run test:lib --watch",
     "build": "pnpm build:rollup && pnpm build:types",
diff --git a/packages/query-async-storage-persister/tsconfig.json b/packages/query-async-storage-persister/tsconfig.json
@@ -1,10 +1,8 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "composite": true,
     "outDir": "./build/lib",
     "rootDir": "./src",
-    "tsBuildInfoFile": "./build/.tsbuildinfo",
     "types": ["vitest/globals"]
   },
   "include": ["src"]
diff --git a/packages/query-broadcast-client-experimental/package.json b/packages/query-broadcast-client-experimental/package.json
@@ -30,7 +30,7 @@
   "scripts": {
     "clean": "rimraf ./build && rimraf ./coverage",
     "test:eslint": "eslint --ext .ts,.tsx ./src",
-    "test:types": "pnpm build:types",
+    "test:types": "tsc --noEmit",
     "build": "pnpm build:rollup && pnpm build:types",
     "build:rollup": "rollup --config rollup.config.mjs",
     "build:types": "tsc --emitDeclarationOnly"
diff --git a/packages/query-broadcast-client-experimental/tsconfig.json b/packages/query-broadcast-client-experimental/tsconfig.json
@@ -1,10 +1,8 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "composite": true,
     "outDir": "./build/lib",
-    "rootDir": "./src",
-    "tsBuildInfoFile": "./build/.tsbuildinfo"
+    "rootDir": "./src"
   },
   "include": ["src"]
 }
diff --git a/packages/query-core/package.json b/packages/query-core/package.json
@@ -30,7 +30,7 @@
   "scripts": {
     "clean": "rimraf ./build && rimraf ./coverage",
     "test:eslint": "eslint --ext .ts,.tsx ./src",
-    "test:types": "pnpm build:types",
+    "test:types": "tsc --noEmit",
     "test:lib": "vitest run --coverage",
     "test:lib:dev": "pnpm run test:lib --watch",
     "build": "pnpm build:rollup && pnpm build:types",
diff --git a/packages/query-core/tsconfig.json b/packages/query-core/tsconfig.json
@@ -1,10 +1,8 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "composite": true,
     "outDir": "./build/lib",
     "rootDir": "./src",
-    "tsBuildInfoFile": "./build/.tsbuildinfo",
     "types": ["vitest/globals"]
   },
   "include": ["src"]
diff --git a/packages/query-devtools/package.json b/packages/query-devtools/package.json
@@ -25,7 +25,7 @@
   "scripts": {
     "clean": "rimraf ./build && rimraf ./coverage",
     "test:eslint": "eslint --ext .ts,.tsx ./src",
-    "test:types": "pnpm build:types",
+    "test:types": "tsc --noEmit",
     "test:lib": "vitest run --coverage",
     "test:lib:dev": "pnpm run test:lib --watch",
     "build": "pnpm build:rollup && pnpm build:types",
diff --git a/packages/query-devtools/tsconfig.json b/packages/query-devtools/tsconfig.json
@@ -1,13 +1,11 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "composite": true,
     "declarationDir": "./build/types",
     "jsx": "preserve",
     "jsxImportSource": "solid-js",
     "outDir": "./build/source",
     "rootDir": "./src",
-    "tsBuildInfoFile": "./build/.tsbuildinfo",
     "types": ["vitest/globals"]
   },
   "include": ["src"]
diff --git a/packages/query-persist-client-core/package.json b/packages/query-persist-client-core/package.json
@@ -30,7 +30,7 @@
   "scripts": {
     "clean": "rimraf ./build && rimraf ./coverage",
     "test:eslint": "eslint --ext .ts,.tsx ./src",
-    "test:types": "pnpm build:types",
+    "test:types": "tsc --noEmit",
     "test:lib": "vitest run --coverage",
     "test:lib:dev": "pnpm run test:lib --watch",
     "build": "pnpm build:rollup && pnpm build:types",
diff --git a/packages/query-persist-client-core/tsconfig.json b/packages/query-persist-client-core/tsconfig.json
@@ -1,10 +1,8 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "composite": true,
     "outDir": "./build/lib",
     "rootDir": "./src",
-    "tsBuildInfoFile": "./build/.tsbuildinfo",
     "types": ["vitest/globals"]
   },
   "include": ["src"]
diff --git a/packages/query-sync-storage-persister/package.json b/packages/query-sync-storage-persister/package.json
@@ -30,7 +30,7 @@
   "scripts": {
     "clean": "rimraf ./build && rimraf ./coverage",
     "test:eslint": "eslint --ext .ts,.tsx ./src",
-    "test:types": "pnpm build:types",
+    "test:types": "tsc --noEmit",
     "test:lib": "vitest run --coverage",
     "test:lib:dev": "pnpm run test:lib --watch",
     "build": "pnpm build:rollup && pnpm build:types",
diff --git a/packages/query-sync-storage-persister/tsconfig.json b/packages/query-sync-storage-persister/tsconfig.json
@@ -1,10 +1,8 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "composite": true,
     "outDir": "./build/lib",
     "rootDir": "./src",
-    "tsBuildInfoFile": "./build/.tsbuildinfo",
     "types": ["vitest/globals"]
   },
   "include": ["src"]
diff --git a/packages/react-query-devtools/package.json b/packages/react-query-devtools/package.json
@@ -40,7 +40,7 @@
   "scripts": {
     "clean": "rimraf ./build && rimraf ./coverage",
     "test:eslint": "eslint --ext .ts,.tsx ./src",
-    "test:types": "pnpm build:types",
+    "test:types": "tsc --noEmit",
     "test:lib": "vitest run --coverage",
     "test:lib:dev": "pnpm run test:lib --watch",
     "build": "pnpm build:rollup && pnpm build:types",
diff --git a/packages/react-query-devtools/tsconfig.json b/packages/react-query-devtools/tsconfig.json
@@ -1,11 +1,9 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "composite": true,
     "jsx": "react",
     "outDir": "./build/lib",
     "rootDir": "./src",
-    "tsBuildInfoFile": "./build/.tsbuildinfo",
     "types": ["vitest/globals"]
   },
   "include": ["src"]
diff --git a/packages/react-query-persist-client/package.json b/packages/react-query-persist-client/package.json
@@ -30,7 +30,7 @@
   "scripts": {
     "clean": "rimraf ./build && rimraf ./coverage",
     "test:eslint": "eslint --ext .ts,.tsx ./src",
-    "test:types": "pnpm build:types",
+    "test:types": "tsc --noEmit",
     "test:lib": "vitest run --coverage",
     "test:lib:dev": "pnpm run test:lib --watch",
     "build": "pnpm build:rollup && pnpm build:types",
diff --git a/packages/react-query-persist-client/tsconfig.json b/packages/react-query-persist-client/tsconfig.json
@@ -1,11 +1,9 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "composite": true,
     "jsx": "react",
     "outDir": "./build/lib",
     "rootDir": "./src",
-    "tsBuildInfoFile": "./build/.tsbuildinfo",
     "types": ["vitest/globals"]
   },
   "include": ["src"]
diff --git a/packages/react-query/package.json b/packages/react-query/package.json
@@ -25,7 +25,7 @@
   "scripts": {
     "clean": "rimraf ./build && rimraf ./coverage",
     "test:eslint": "eslint --ext .ts,.tsx ./src",
-    "test:types": "pnpm build:types",
+    "test:types": "tsc --noEmit",
     "test:lib": "vitest run --coverage",
     "test:lib:dev": "pnpm run test:lib --watch",
     "build": "pnpm build:rollup && pnpm build:codemods && pnpm build:types",
diff --git a/packages/react-query/tsconfig.json b/packages/react-query/tsconfig.json
@@ -1,11 +1,9 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "composite": true,
     "jsx": "react",
     "outDir": "./build/lib",
     "rootDir": "./src",
-    "tsBuildInfoFile": "./build/.tsbuildinfo",
     "types": ["vitest/globals"]
   },
   "include": ["src"]
diff --git a/packages/solid-query/package.json b/packages/solid-query/package.json
@@ -34,7 +34,7 @@
   "scripts": {
     "clean": "rimraf ./build && rimraf ./coverage",
     "test:eslint": "eslint --ext .ts,.tsx ./src",
-    "test:types": "pnpm build:types",
+    "test:types": "tsc --noEmit",
     "test:lib": "vitest run --coverage",
     "test:lib:dev": "pnpm run test:lib --watch",
     "build": "pnpm build:rollup && pnpm build:types",
diff --git a/packages/solid-query/tsconfig.json b/packages/solid-query/tsconfig.json
@@ -1,13 +1,11 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "composite": true,
     "declarationDir": "./build/types",
     "jsx": "preserve",
     "jsxImportSource": "solid-js",
     "outDir": "./build/source",
     "rootDir": "./src",
-    "tsBuildInfoFile": "./build/.tsbuildinfo",
     "types": ["vitest/globals"]
   },
   "include": ["src", "createInfiniteQuery.test.tsx", "suspense.test.tsx"]
diff --git a/packages/svelte-query/package.json b/packages/svelte-query/package.json
@@ -31,7 +31,7 @@
   ],
   "scripts": {
     "clean": "rimraf ./build && rimraf ./coverage",
-    "test:types": "svelte-check --tsconfig ./tsconfig.json && pnpm build",
+    "test:types": "svelte-check --tsconfig ./tsconfig.json",
     "test:eslint": "eslint --ext .svelte,.ts ./src",
     "test:lib": "vitest run --coverage",
     "test:lib:dev": "pnpm run test:lib --watch",
diff --git a/packages/vue-query/package.json b/packages/vue-query/package.json
@@ -29,7 +29,7 @@
   "scripts": {
     "clean": "rimraf ./build && rimraf ./coverage",
     "test:eslint": "eslint --ext .ts,.tsx ./src",
-    "test:types": "pnpm build:types",
+    "test:types": "tsc --noEmit",
     "test:lib": "pnpm run test:2 && pnpm run test:2.7 && pnpm run test:3",
     "test:2": "vue-demi-switch 2 vue2 && vitest",
     "test:2.7": "vue-demi-switch 2.7 vue2.7 && vitest",
diff --git a/packages/vue-query/tsconfig.json b/packages/vue-query/tsconfig.json
@@ -1,10 +1,8 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "composite": true,
     "outDir": "./build/lib",
     "rootDir": "./src",
-    "tsBuildInfoFile": "./build/.tsbuildinfo",
     "types": ["vitest/globals"]
   },
   "include": ["src"]

Original file line number	Diff line number	Diff line change
`@@ -1,10 +1,8 @@`
`1`	`1`	`{`
`2`	`2`	`"extends": "../../tsconfig.json",`
`3`	`3`	`"compilerOptions": {`
`4`		`- "composite": true,`
`5`	`4`	`"outDir": "./build/lib",`
`6`		`- "rootDir": "./src",`
`7`		`- "tsBuildInfoFile": "./build/.tsbuildinfo"`
	`5`	`+ "rootDir": "./src"`
`8`	`6`	`},`
`9`	`7`	`"include": ["src"]`
`10`	`8`	`}`