Resume onSelect tracking after dragend (facebook#13422)

Author: gaearon

packages/react-dom/src/events/SelectEventPlugin.js

@@ -14,6 +14,7 @@ import shallowEqual from 'shared/shallowEqual';
 import {
   TOP_BLUR,
   TOP_CONTEXT_MENU,
+  TOP_DRAG_END,
   TOP_FOCUS,
   TOP_KEY_DOWN,
   TOP_KEY_UP,
@@ -39,6 +40,7 @@ const eventTypes = {
     dependencies: [
       TOP_BLUR,
       TOP_CONTEXT_MENU,
+      TOP_DRAG_END,
       TOP_FOCUS,
       TOP_KEY_DOWN,
       TOP_KEY_UP,
@@ -200,6 +202,7 @@ const SelectEventPlugin = {
         break;
       case TOP_CONTEXT_MENU:
       case TOP_MOUSE_UP:
+      case TOP_DRAG_END:
         mouseDown = false;
         return constructSelectEvent(nativeEvent, nativeEventTarget);
       // Chrome and IE fire non-standard event when selection is changed (and

packages/react-dom/src/events/__tests__/SelectEventPlugin-test.js

@@ -108,4 +108,39 @@ describe('SelectEventPlugin', () => {
     node.dispatchEvent(nativeEvent);
     expect(select).toHaveBeenCalledTimes(1);
   });
+
+  // Regression test for https://github.com/facebook/react/issues/11379
+  it('should not wait for `mouseup` after receiving `dragend`', () => {
+    const select = jest.fn();
+    const onSelect = event => {
+      expect(typeof event).toBe('object');
+      expect(event.type).toBe('select');
+      expect(event.target).toBe(node);
+      select(event.currentTarget);
+    };
+
+    const node = ReactDOM.render(
+      <input type="text" onSelect={onSelect} />,
+      container,
+    );
+    node.focus();
+
+    let nativeEvent = new MouseEvent('focus', {
+      bubbles: true,
+      cancelable: true,
+    });
+    node.dispatchEvent(nativeEvent);
+    expect(select).toHaveBeenCalledTimes(0);
+
+    nativeEvent = new MouseEvent('mousedown', {
+      bubbles: true,
+      cancelable: true,
+    });
+    node.dispatchEvent(nativeEvent);
+    expect(select).toHaveBeenCalledTimes(0);
+
+    nativeEvent = new MouseEvent('dragend', {bubbles: true, cancelable: true});
+    node.dispatchEvent(nativeEvent);
+    expect(select).toHaveBeenCalledTimes(1);
+  });
 });