This repository was archived by the owner on May 29, 2019. It is now read-only.
feat(tooltip/popover): fix -class option for other tooltip/popup types#3569
Closed
chrisirhc wants to merge 2 commits intoangular-ui:masterfrom
Closed
feat(tooltip/popover): fix -class option for other tooltip/popup types#3569chrisirhc wants to merge 2 commits intoangular-ui:masterfrom
chrisirhc wants to merge 2 commits intoangular-ui:masterfrom
Conversation
Contributor
|
LGTM |
Contributor
|
@chrisirhc #3563 is merged. Can you take a look at this PR to verify it's still able to merge? |
Contributor
|
Needs work now, merge conflict. |
- Test each option for each tooltip type - Tooltip popup now uses tooltip-classes directive
Make this consistent with tooltips.
chrisirhc
force-pushed
the
feature/tip-respect-class
branch
from
9c86e9e to
5f76fa0
Compare
Contributor
Author
|
Rebased :) |
chrisirhc
added a commit
that referenced
this pull request
Apr 30, 2015
This functionality now works the same between tooltips and popovers. Closes #3569
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on commits in #3563 . Should merge only after #3563 is merged.