fix(secret): ignore .dist-info directories during secret scanning#8646
Merged
DmitriyLewen merged 2 commits intoaquasecurity:mainfrom Apr 7, 2025
Merged
fix(secret): ignore .dist-info directories during secret scanning#8646DmitriyLewen merged 2 commits intoaquasecurity:mainfrom
DmitriyLewen merged 2 commits intoaquasecurity:mainfrom
Conversation
|
|
DmitriyLewen
approved these changes
Apr 1, 2025
Contributor
DmitriyLewen
left a comment
DmitriyLewen
left a comment
There was a problem hiding this comment.
@ATIC-Yugandhar Thanks for your work!
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
According to Python packaging standards,
.dist-infodirectories contain only metadata files such as version, license, and entry points. These directories are typically placed alongside installed packages insite-packages.Since Trivy's secret scanner does not need to scan these metadata files, doing so can lead to false positives. Therefore, we can safely exclude
.dist-infodirectories using a built-in allow rule.Reference:
Changes
.dist-info/directories from secret scanningMustCompilepattern used for other excluded pathsRelated Links
builtin-allow-rules.goFixes
Fixes #8212
Checklist