Skip to content

Commit 9ce407f

Browse files
iandelahornerbreeze
authored andcommitted
fix: Add namespace to sub-application link URLs (#11946)
Signed-off-by: Ian Delahorne <ian@patreon.com> Co-authored-by: Remington Breeze <remington@breeze.software>
1 parent bbe870f commit 9ce407f

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

USERS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,7 @@ Currently, the following organizations are **officially** using Argo CD:
155155
1. [Packlink](https://www.packlink.com/)
156156
1. [Pandosearch](https://www.pandosearch.com/en/home)
157157
1. [PagerDuty](https://www.pagerduty.com/)
158+
1. [Patreon](https://www.patreon.com/)
158159
1. [PayPay](https://paypay.ne.jp/)
159160
1. [Peloton Interactive](https://www.onepeloton.com/)
160161
1. [Pipefy](https://www.pipefy.com/)

ui/src/app/applications/components/application-details/application-resource-list.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export const ApplicationResourceList = ({
4646
<Consumer>
4747
{ctx => (
4848
<span className='application-details__external_link'>
49-
<a href={ctx.baseHref + 'applications/' + res.name} title='Open application'>
49+
<a href={ctx.baseHref + 'applications/' + res.namespace + '/' + res.name} title='Open application'>
5050
<i className='fa fa-external-link-alt' />
5151
</a>
5252
</span>

ui/src/app/applications/components/application-resource-tree/application-resource-tree.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,7 @@ function renderPodGroup(props: ApplicationResourceTreeProps, id: string, node: R
433433
{appNode && !rootNode && (
434434
<Consumer>
435435
{ctx => (
436-
<a href={ctx.baseHref + 'applications/' + node.name} title='Open application'>
436+
<a href={ctx.baseHref + 'applications/' + node.namespace + '/' + node.name} title='Open application'>
437437
<i className='fa fa-external-link-alt' />
438438
</a>
439439
)}
@@ -652,7 +652,7 @@ function renderResourceNode(props: ApplicationResourceTreeProps, id: string, nod
652652
{appNode && !rootNode && (
653653
<Consumer>
654654
{ctx => (
655-
<a href={ctx.baseHref + 'applications/' + node.name} title='Open application'>
655+
<a href={ctx.baseHref + 'applications/' + node.namespace + '/' + node.name} title='Open application'>
656656
<i className='fa fa-external-link-alt' />
657657
</a>
658658
)}

0 commit comments

Comments
 (0)