Skip to content

Commit 9cef28d

Browse files
committed
Update isTrue/isFalse failure message
1 parent bd57c00 commit 9cef28d

3 files changed

Lines changed: 7 additions & 8 deletions

File tree

assertk/src/commonMain/kotlin/assertk/assertions/boolean.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,14 @@ package assertk.assertions
22

33
import assertk.Assert
44
import assertk.assertions.support.expected
5-
import assertk.assertions.support.fail
65

76
/**
87
* Asserts the boolean is true.
98
* @see [isFalse]
109
*/
1110
fun Assert<Boolean?>.isTrue() = given { actual ->
1211
if (actual == true) return
13-
fail(true, actual)
12+
expected("to be true but was $actual")
1413
}
1514

1615
/**
@@ -19,5 +18,5 @@ fun Assert<Boolean?>.isTrue() = given { actual ->
1918
*/
2019
fun Assert<Boolean?>.isFalse() = given { actual ->
2120
if (actual == false) return
22-
fail(false, actual)
21+
expected("to be false but was $actual")
2322
}

assertk/src/commonTest/kotlin/test/assertk/TableTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ class TableTest {
8888
assertEquals(
8989
"""The following assertion failed
9090
|${"\t"}on row:(a=<false>)
91-
|${"\t"}expected:<[tru]e> but was:<[fals]e>
91+
|${"\t"}expected to be true but was false
9292
""".trimMargin(),
9393
error.message
9494
)

assertk/src/commonTest/kotlin/test/assertk/assertions/BooleanTest.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,15 @@ class BooleanTest {
1919
val error = assertFailsWith<AssertionError> {
2020
assertThat(false).isTrue()
2121
}
22-
assertEquals("expected:<[tru]e> but was:<[fals]e>", error.message)
22+
assertEquals("expected to be true but was false", error.message)
2323
}
2424

2525
@Test
2626
fun isTrue_null_value_fails() {
2727
val error = assertFailsWith<AssertionError> {
2828
assertThat(null as Boolean?).isTrue()
2929
}
30-
assertEquals("expected:<true> but was:<null>", error.message)
30+
assertEquals("expected to be true but was null", error.message)
3131
}
3232
//endregion
3333

@@ -42,15 +42,15 @@ class BooleanTest {
4242
val error = assertFailsWith<AssertionError> {
4343
assertThat(true).isFalse()
4444
}
45-
assertEquals("expected:<[fals]e> but was:<[tru]e>", error.message)
45+
assertEquals("expected to be false but was true", error.message)
4646
}
4747

4848
@Test
4949
fun isFalse_null_value_fails() {
5050
val error = assertFailsWith<AssertionError> {
5151
assertThat(null as Boolean?).isFalse()
5252
}
53-
assertEquals("expected:<false> but was:<null>", error.message)
53+
assertEquals("expected to be false but was null", error.message)
5454
}
5555
//endregion
5656
}

0 commit comments

Comments
 (0)