fix: CFn CustomResources shouldn't change PhysicalResourceId in Delete requests

Author: Youssef-Beltagy

cfn/wrap.go

@@ -6,6 +6,7 @@ import (
 	"context"
 	"encoding/json"
 	"errors"
+	"fmt"
 	"log"
 	"net/http"
 
@@ -58,6 +59,10 @@ func lambdaWrapWithClient(lambdaFunction CustomResourceFunction, client httpClie
 			r.Status = StatusFailed
 			r.Reason = err.Error()
 			log.Printf("sending status failed: %s", r.Reason)
+		} else if event.RequestType == RequestDelete && event.PhysicalResourceID != r.PhysicalResourceID {
+			r.Status = StatusFailed
+			r.Reason = fmt.Sprintf("DELETE: cannot change the physical resource ID from %s to %s during deletion", event.PhysicalResourceID, r.PhysicalResourceID)
+			log.Printf("sending status failed: %s", r.Reason)
 		} else {
 			r.Status = StatusSuccess
 		}