Merge pull request #173 from browserstack/wmic_deprecation

Remove ps-tree dependency which uses deprecated wmic, replace it with tree-kill

Author: AdityaHirapara

lib/Local.js

@@ -7,7 +7,7 @@ var childProcess = require('child_process'),
   LocalBinary = require('./LocalBinary'),
   LocalError = require('./LocalError'),
   version = require('../package.json').version,
-  psTree = require('ps-tree');
+  treeKill = require('tree-kill');
 
 function Local(){
   this.sanitizePath = function(rawPath) {
@@ -342,32 +342,7 @@ function Local(){
   };
 
   this.killAllProcesses = function(callback){
-    psTree(this.pid, (err, children) => {
-      var childPids = children.map(val => val.PID);
-      var killChecker = setInterval(() => {
-        if(childPids.length === 0) {
-          clearInterval(killChecker);
-          try {
-            process.kill(this.pid);
-            // This gives time to local binary to send kill signal to railsApp.
-            setTimeout(() => {
-              this.isProcessRunning = false;
-              callback();
-            }, 2000);
-          } catch(err) {
-            this.isProcessRunning = false;
-            callback();
-          }
-        }
-        for(var i in childPids) {
-          try {
-            process.kill(childPids[i]);
-          } catch(err) {
-            childPids.splice(i, 1);
-          }
-        }
-      },500);
-    });
+    treeKill(this.pid, 'SIGTERM', callback);
   };
 }
 

package-lock.json

@@ -21,7 +21,7 @@
     "agent-base": "^6.0.2",
     "https-proxy-agent": "^5.0.1",
     "is-running": "^2.1.0",
-    "ps-tree": "=1.2.0"
+    "tree-kill": "^1.2.2"
   },
   "devDependencies": {
     "eslint": "^7.0.0",