Commit 40d469f
committed
Skip affected test cases to avoid bogus test failure on PHP 7.4
The build error on PHP 7.4 will be addressed via
reactphp/dns#164. Interestingly, it fails in the
`FunctionalResolverTest` class and does not fail anymore by excluding
some other test cases. It can only be reproduced by running:
```
$ vendor/bin/phpunit --coverage-text --exclude-group internet
```
It can not be reproduced when running on any other PHP version, when
`ext-xdebug` is disabled, when coverage is not collected or when not
excluding this group.
This means the test failure is bogus.
We work around this by temporarily skipping some test case for now.1 parent 52f330e commit 40d469f
1 file changed
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
7 | 11 | | |
8 | 12 | | |
9 | 13 | | |
| |||
0 commit comments