Skip to content

Commit bf0aacf

Browse files
fixes: Renamed ConfigAnalyse in ConfigAnalysisConclusion
1 parent 9e4b9d3 commit bf0aacf

7 files changed

Lines changed: 11 additions & 11 deletions

File tree

src/BenchmarkDotNet/Configs/DebugConfig.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,6 @@ public string ArtifactsPath
8585

8686
public ConfigOptions Options => ConfigOptions.KeepBenchmarkFiles | ConfigOptions.DisableOptimizationsValidator;
8787

88-
public IReadOnlyList<Conclusion> ConfigAnalyse => emptyConclusion;
88+
public IReadOnlyList<Conclusion> ConfigAnalysisConclusion => emptyConclusion;
8989
}
9090
}

src/BenchmarkDotNet/Configs/DefaultConfig.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ public string ArtifactsPath
9292
}
9393
}
9494

95-
public IReadOnlyList<Conclusion> ConfigAnalyse => emptyConclusion;
95+
public IReadOnlyList<Conclusion> ConfigAnalysisConclusion => emptyConclusion;
9696

9797
public IEnumerable<Job> GetJobs() => Array.Empty<Job>();
9898

src/BenchmarkDotNet/Configs/IConfig.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,6 @@ public interface IConfig
5555
/// <summary>
5656
/// Collect any errors or warnings when composing the configuration
5757
/// </summary>
58-
IReadOnlyList<Conclusion> ConfigAnalyse { get; }
58+
IReadOnlyList<Conclusion> ConfigAnalysisConclusion { get; }
5959
}
6060
}

src/BenchmarkDotNet/Configs/ImmutableConfig.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ internal ImmutableConfig(
5050
IOrderer orderer,
5151
SummaryStyle summaryStyle,
5252
ConfigOptions options,
53-
TimeSpan buildTimeout)
54-
IReadOnlyList<Conclusion> configAnalyse)
53+
TimeSpan buildTimeout,
54+
IReadOnlyList<Conclusion> configAnalysisConclusion)
5555
{
5656
columnProviders = uniqueColumnProviders;
5757
loggers = uniqueLoggers;
@@ -70,7 +70,7 @@ internal ImmutableConfig(
7070
SummaryStyle = summaryStyle;
7171
Options = options;
7272
BuildTimeout = buildTimeout;
73-
ConfigAnalyse = configAnalyse;
73+
ConfigAnalysisConclusion = configAnalysisConclusion;
7474
}
7575

7676
public ConfigUnionRule UnionRule { get; }
@@ -111,6 +111,6 @@ public IDiagnoser GetCompositeDiagnoser(BenchmarkCase benchmarkCase, RunMode run
111111
return diagnosersForGivenMode.Any() ? new CompositeDiagnoser(diagnosersForGivenMode) : null;
112112
}
113113

114-
public IReadOnlyList<Conclusion> ConfigAnalyse { get; private set; }
114+
public IReadOnlyList<Conclusion> ConfigAnalysisConclusion { get; private set; }
115115
}
116116
}

src/BenchmarkDotNet/Configs/ManualConfig.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public class ManualConfig : IConfig
5151
[PublicAPI] public SummaryStyle SummaryStyle { get; set; }
5252
[PublicAPI] public TimeSpan BuildTimeout { get; set; } = DefaultConfig.Instance.BuildTimeout;
5353

54-
public IReadOnlyList<Conclusion> ConfigAnalyse => emptyConclusion;
54+
public IReadOnlyList<Conclusion> ConfigAnalysisConclusion => emptyConclusion;
5555

5656
public ManualConfig WithOption(ConfigOptions option, bool value)
5757
{

src/BenchmarkDotNet/Running/BenchmarkRunnerClean.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,10 +255,10 @@ private static void PrintSummary(ILogger logger, ImmutableConfig config, Summary
255255
// TODO: make exporter
256256
ConclusionHelper.Print(logger, config.GetCompositeAnalyser().Analyse(summary).Distinct().ToList());
257257

258-
if (config.ConfigAnalyse.Any())
258+
if (config.ConfigAnalysisConclusion.Any())
259259
{
260260
logger.WriteLineHeader("// * Config Issues *");
261-
ConclusionHelper.Print(logger, config.ConfigAnalyse);
261+
ConclusionHelper.Print(logger, config.ConfigAnalysisConclusion);
262262
}
263263

264264
// TODO: move to conclusions

tests/BenchmarkDotNet.Tests/Configs/ImmutableConfigTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,7 @@ public void GenerateWarningWhenExporterDependencyAlreadyExistInConfig()
397397

398398
var final = ImmutableConfigBuilder.Create(mutable);
399399

400-
Assert.Equal(1, final.ConfigAnalyse.Count);
400+
Assert.Equal(1, final.ConfigAnalysisConclusion.Count);
401401
}
402402
finally
403403
{

0 commit comments

Comments
 (0)