Commit 48a96b1
committed
[MediaCapabilities][GStreamer] Check audio codecs support isConfigurationSupported()
https://bugs.webkit.org/show_bug.cgi?id=310195
Reviewed by NOBODY (OOPS!).
Currently, isConfigurationSupported() only validates video codecs
against the registered decoder/encoder map. Audio codecs from the audio
configuration were never checked, so unsupported audio codecs could
incorrectly be reported as supported.
See: WebPlatformForEmbedded/WPEWebKit#1640
Fix this by collecting codec strings from both the video and audio
ContentType objects into a single vector and running the software codec
support checks once on the combined list at the end of the function.
Audio hardware accelerated decoding doesn't save much CPU power compared
to video accelerated decoding, and we don't want to reject a video+audio
codec combination just because the audio part isn't accelerated. That's
why the hardware accelerated decoding support checks are only run on the
video codecs.
Co-authored by: Andrzej Surdej (https://github.com/asurdej-comcast)
* Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::isConfigurationSupported const): Collect audio codecs and run the codec checks.1 parent 06f70da commit 48a96b1
1 file changed
Lines changed: 14 additions & 7 deletions
Lines changed: 14 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1030 | 1030 | | |
1031 | 1031 | | |
1032 | 1032 | | |
1033 | | - | |
1034 | 1033 | | |
1035 | 1034 | | |
1036 | 1035 | | |
1037 | 1036 | | |
| 1037 | + | |
| 1038 | + | |
| 1039 | + | |
1038 | 1040 | | |
1039 | 1041 | | |
1040 | 1042 | | |
| |||
1064 | 1066 | | |
1065 | 1067 | | |
1066 | 1068 | | |
1067 | | - | |
1068 | | - | |
1069 | | - | |
1070 | | - | |
1071 | | - | |
1072 | | - | |
| 1069 | + | |
| 1070 | + | |
1073 | 1071 | | |
1074 | 1072 | | |
1075 | 1073 | | |
| |||
1082 | 1080 | | |
1083 | 1081 | | |
1084 | 1082 | | |
| 1083 | + | |
| 1084 | + | |
| 1085 | + | |
| 1086 | + | |
| 1087 | + | |
| 1088 | + | |
| 1089 | + | |
| 1090 | + | |
| 1091 | + | |
1085 | 1092 | | |
1086 | 1093 | | |
1087 | 1094 | | |
| |||
0 commit comments